879246 - Intermittent test_sourcemaps-02.js | test failed (with xpcshell return code: 0) | false == true | test_sourcemaps-06.js | test failed (with xpcshell return code: 0) | /* Any copyright is dedicated to the Public Domain.

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=23746039&tree=Mozilla-Inbound

WINNT 6.2 mozilla-inbound pgo test xpcshell on 2013-06-03 18:18:04 PDT for push 7e3a4ebcf067
slave: t-w864-ix-119

18:23:16     INFO -  TEST-INFO | C:\slave\test\build\tests\xpcshell\tests\toolkit\devtools\server\tests\unit\test_sourcemaps-02.js | running test ...
18:23:16  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\devtools\server\tests\unit\test_sourcemaps-02.js | test failed (with xpcshell return code: 0), see following log:
...
18:23:16     INFO -  TEST-PASS | undefined | [undefined : undefined] true == true
18:23:16     INFO -  TEST-PASS | undefined | [undefined : undefined] true == true
18:23:16     INFO -  TEST-PASS | undefined | [undefined : undefined] true == true
18:23:16     INFO -  TEST-PASS | undefined | [undefined : undefined] true == true
18:23:16  WARNING -  TEST-UNEXPECTED-FAIL |  | false == true - See following stack:
18:23:16     INFO -  The source's url should be one of our original sources
18:23:16     INFO -  TEST-INFO | (xpcshell/head.js) | exiting test
...
18:23:17     INFO -  TEST-INFO | C:\slave\test\build\tests\xpcshell\tests\toolkit\devtools\server\tests\unit\test_sourcemaps-06.js | running test ...
18:23:17  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\devtools\server\tests\unit\test_sourcemaps-06.js | test failed (with xpcshell return code: 0), see following log:
18:23:17     INFO -  >>>>>>>
...
18:23:17     INFO -  TEST-PASS | undefined | [undefined : undefined] true == true
18:23:17  WARNING -  TEST-UNEXPECTED-FAIL |  | /* Any copyright is dedicated to the Public Domain.
18:23:17     INFO -     http://creativecommons.org/publicdomain/zero/1.0/ */
18:23:17     INFO -  "use strict";

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

This source is not expected in the test:

18:23:16     INFO -      {
18:23:16     INFO -        "actor": "conn0.source8",
18:23:16     INFO -        "url": "C:/slave/test/build/tests/xpcshell/tests/toolkit/devtools/server/tests/unit/head_dbg.js"
18:23:16     INFO -      }

However, if it was already there before we eval the source mapped code (I suspect this is the case here), it makes sense it would show up again in the sources repsonse.

If we change the test to either add all sources that exist before we eval any code to expectedSources in the test, or some other way of ignoring those existing sources, the test should succeed.

However, why is there a source showing up here in the first place? Panos, is this an issue where we need to call gc() before beginning like some of the other debugger xpcshell tests?

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

head_dbg.js appears as a newSource packet first, after the source-mapped files appear, so this must be a separate instance from the one loaded for the test file. Maybe the xpcshell harness loads it for every eval/evalInSandbox call, not sure. 

The gc() trick we use in other tests clears any remnants of eval scripts, so if you can arrange for a gc right before calling getSources() this might fix the problem. Just make sure you don't just call getSources() after 3 newSource events, but after you get the sources you were expecting to get.

Another approach would be to look specifically for the 3 scripts you expect and ignore any others. I'm fine either way.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: v1

https://tbpl.mozilla.org/?tree=Try&rev=b51c3ad27cb2

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 758158 [details] [diff] [review]
v1

Review of attachment 758158 [details] [diff] [review]:
-----------------------------------------------------------------

No gc(), eh? OK.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/0f23a2e50620

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f23a2e50620

Comment 7

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=23884062&tree=Birch
WINNT 6.2 birch pgo test xpcshell on 2013-06-06 18:12:51
slave: t-w864-ix-018

18:17:52  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\devtools\server\tests\unit\test_sourcemaps-06.js | test failed (with xpcshell return code: 0), see following log:
18:17:52  WARNING -  TEST-UNEXPECTED-FAIL |  | /* Any copyright is dedicated to the Public Domain.
19:15:39    ERROR - Return code: 1

Comment 8

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=24459119&tree=Birch
WINNT 6.2 birch pgo test xpcshell on 2013-06-21 21:49:04
revision: 1c3fa2ce8dea
slave: t-w864-ix-048

22:23:20  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\devtools\server\tests\unit\test_sourcemaps-06.js | test failed (with xpcshell return code: 0), see following log:
22:23:20  WARNING -  TEST-UNEXPECTED-FAIL |  | "/* Any copyright is dedicated to the Public Domain.
22:54:46    ERROR - Return code: 1