All users were logged out of Bugzilla on October 13th, 2018

jniregen.pl doesn't work on windows

RESOLVED FIXED in 3.3

Status

P1
normal
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: jamie-bugzilla, Assigned: jamie-bugzilla)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
The problem is that when Perl executes another program (javah), it parses the
argument list using the Windows cmd shell. There's no
way to override the shell. cmd doesn't understand single quotes, so it doesn't
strip them off. Javah was getting its classpath argument
surrounded by single quotes, which is an invalid classpath, so it couldn't find
the class. 

My fix is to substitute double quotes for single quotes in the command before
passing it to system(), which will work as long as the command doesn't have
anything tricky in it. I don't see a situation where this would happen.
(Assignee)

Comment 1

18 years ago
Created attachment 40205 [details] [diff] [review]
patch to fix quoting
(Assignee)

Comment 2

18 years ago
This breaks the build under some situations, so it needs to get fixed.
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → 3.3
(Assignee)

Comment 3

18 years ago
Fixed by making that patch to jniregen.pl.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.