879292 - Remove unused code

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Evyatar 'Tron' Amitay (everything.me)]

There are a couple of modules, Tips and Dialogs, that aren't being used anymore.
Removing them will make the code easier to maintain, and will make e.me load faster.

Comment 1

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 757962 [details]
Patch - redirect to github PR

Cool

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

merged into master
2b082341611a6c744cce9613a9aaa72900191e79

https://github.com/mozilla-b2g/gaia/commit/2b082341611a6c744cce9613a9aaa72900191e79

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

This will have to ride the trains, at this point only bugs with partner championing will be marked blocking by partners.

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Now that https://bugzilla.mozilla.org/show_bug.cgi?id=838634 is getting merged into leo, it's a good time to merge this fix in.

It removes the annoying tips for new users. Now that Evme is moving to the landing page it's even more prominent.

The fix is code removal only, has been in master for 2 months without any repercussions - no reason not to make it in IMO. Vivien is for it as well.

Comment 6

[Preeti Raghunath(:Preeti)]

minusing this bug.