Closed Bug 879316 Opened 7 years ago Closed 7 years ago

Tweaking CSP violation message logging

Categories

(Core :: Security, defect, P2, trivial)

defect

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: freddyb, Assigned: freddyb)

References

Details

Attachments

(1 file)

This bug covers preliminary work on bug 607067.
I have removed duplicate logging code and removed "WARN"/"ERROR" strings as hard coded prefixes from the code. The current "CSP" prefix has also been expanded to say "Content Security Policy".
With Garrett's work in bug 871491, this should already look much nicer.

Patch attached.
Sid, can you take a look please?
Attachment #757978 - Flags: review?(sstamm)
I didn't change that much, but I'd like to have another review instead of carrying over the one from bug 607067 - just to be sure.
Attachment #757978 - Flags: review?(imelven)
Comment on attachment 757978 [details] [diff] [review]
attachment from 607067 without the l10n changes

Review of attachment 757978 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, sorry this review took so long !
Attachment #757978 - Flags: review?(imelven) → review+
Thanks :)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3890895968af
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Attachment #757978 - Flags: review?(sstamm)
You need to log in before you can comment on or make changes to this bug.