Last Comment Bug 879316 - Tweaking CSP violation message logging
: Tweaking CSP violation message logging
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security (show other bugs)
: Trunk
: All All
: P2 trivial (vote)
: mozilla24
Assigned To: Frederik Braun [:freddyb]
:
: David Keeler [:keeler] (use needinfo?)
Mentors:
Depends on:
Blocks: 607067
  Show dependency treegraph
 
Reported: 2013-06-04 09:16 PDT by Frederik Braun [:freddyb]
Modified: 2013-08-12 09:11 PDT (History)
11 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
attachment from 607067 without the l10n changes (11.88 KB, patch)
2013-06-04 09:16 PDT, Frederik Braun [:freddyb]
ian.melven: review+
Details | Diff | Splinter Review

Description Frederik Braun [:freddyb] 2013-06-04 09:16:58 PDT
Created attachment 757978 [details] [diff] [review]
attachment from 607067 without the l10n changes

This bug covers preliminary work on bug 607067.
I have removed duplicate logging code and removed "WARN"/"ERROR" strings as hard coded prefixes from the code. The current "CSP" prefix has also been expanded to say "Content Security Policy".
With Garrett's work in bug 871491, this should already look much nicer.

Patch attached.
Sid, can you take a look please?
Comment 1 Frederik Braun [:freddyb] 2013-06-06 02:38:06 PDT
I didn't change that much, but I'd like to have another review instead of carrying over the one from bug 607067 - just to be sure.
Comment 2 Ian Melven :imelven 2013-06-13 17:53:23 PDT
Comment on attachment 757978 [details] [diff] [review]
attachment from 607067 without the l10n changes

Review of attachment 757978 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, sorry this review took so long !
Comment 3 Frederik Braun [:freddyb] 2013-06-14 05:02:13 PDT
Thanks :)
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-06-14 06:09:41 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3890895968af
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-06-14 18:59:27 PDT
https://hg.mozilla.org/mozilla-central/rev/3890895968af

Note You need to log in before you can comment on or make changes to this bug.