879335 - Remove WebRTC + permissions from Firefox 23

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Firefox 23 currently contains very preliminary WebRTC support, and adds the permissions required for that. As the support is a bit too rudimentary to be very useful even for most developers, and we prefer to group new permissions being added to Fennec:

1) Disable WebRTC building on Firefox 23.
2) Remove the WebRTC permissions from the Android Manifest (prolly automatic as a result of (1), but let's check!)

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Disable WebRTC building.

Tested on try, verified resulting APK no longer requests the new permissions.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 758714 [details] [diff] [review]
Patch 1. Disable WebRTC building.

Review of attachment 758714 [details] [diff] [review]:
-----------------------------------------------------------------

to be landed on 23 only

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 758714 [details] [diff] [review]
Patch 1. Disable WebRTC building.

This patch disables WebRTC on Firefox 23 - too much bugs remaining, too late to land the permissions and notification UI for it.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): WebRTC for Android
User impact if declined: Need to manually approve Firefox update in Google Play, for a feature that is mostly unusable.
Testing completed (on m-c, etc.): Local only. Build config change.
Risk to taking this patch (and alternatives if risky): Failure to disable a feature at build time.
String or IDL/UUID changes made by this patch: None.

Comment 4

[bhavana bajaj [:bajaj]]

(Tracking, in case we have to disable later on for Fx24 as well)

Comment 5

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e6171d538fc6

Comment 6

[Jason Smith [:jsmith]]

I'm assuming the landing in comment 5 means we close this, as this is Aurora-only bug and does not require a central landing.

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Backed out:
https://hg.mozilla.org/releases/mozilla-aurora/rev/27bcde94e2ee

It looks like this needs to land together with a backout of bug 867778 on Aurora.

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Bug 862883 also needs to be backed out.

Comment 9

[Jason Smith [:jsmith]]

(In reply to Gian-Carlo Pascutto (:gcp) from comment #8)
> Bug 862883 also needs to be backed out.

Either that or we could just turn the mochitests off for Fx23 in the android exclude list. In fact, doing the exclude list change would probably be easier.

Comment 10

[Gian-Carlo Pascutto [:gcp]]

>In fact, doing the exclude list change would probably be easier.

Can you make a patch for this?

Comment 11

[Jason Smith [:jsmith]]

Attachment: Disable WebRTC Automation on FxAndroid 23

Comment 12

[Jason Smith [:jsmith]]

Comment on attachment 764533 [details] [diff] [review]
Disable WebRTC Automation on FxAndroid 23

Review of attachment 764533 [details] [diff] [review]:
-----------------------------------------------------------------

Try running coming shortly.

Comment 13

[Jason Smith [:jsmith]]

Comment on attachment 764533 [details] [diff] [review]
Disable WebRTC Automation on FxAndroid 23

Screwed up here. Let me pull my tree correctly this time...

Comment 14

[Jason Smith [:jsmith]]

Attachment: Disable WebRTC Automation on FxAndroid 23

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 764547 [details] [diff] [review]
Disable WebRTC Automation on FxAndroid 23

Review of attachment 764547 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me but please come up with a try server run, which proves that all is fine and we do not miss something. Thanks.

Comment 16

[Jason Smith [:jsmith]]

gcp - patch is ready to go. Do you want to kick off a try run with your patch and my patch to see if we're green?

Comment 17

[Jason Smith [:jsmith]]

Actually disregard. I can probably do it.

Comment 18

[Jason Smith [:jsmith]]

https://tbpl.mozilla.org/?tree=Try&rev=9089cd857a49

Comment 19

[Jason Smith [:jsmith]]

Comment on attachment 764547 [details] [diff] [review]
Disable WebRTC Automation on FxAndroid 23

[Approval Request Comment]
Bug caused by (feature/regressing bug #): WebRTC on FxAndroid on 23.
User impact if declined: Won't be able to turn off WebRTC on FxAndroid on 23, resulting in issues mentioned in other approval request.
Testing completed (on m-c, etc.): Buildbot run kicked off, if green, should indicate we're okay.
Risk to taking this patch (and alternatives if risky): None - this is a test only patch.
String or IDL/UUID changes made by this patch: None

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Jason Smith [:jsmith] from comment #19)
> Risk to taking this patch (and alternatives if risky): None - this is a test
> only patch.

This patch doesn't need approval to get landed on aurora. Just include a=test-only in the commit message and get it landed.

Comment 21

[Jason Smith [:jsmith]]

Try run is green across the board. Let's land this on Aurora

Comment 22

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bab83a050841
https://hg.mozilla.org/releases/mozilla-aurora/rev/1f5795c8cefd