879362 - [A/V][video] When YouTube video completes, UX (Pause button, timer) is ambiguous

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Screenshot of Video app

Observed while trying to reproduce bug 870564.

STR:
1. play YouTube video https://www.youtube.com/watch?v=V1IBH1bz5-c through to the end*

Expected behaviour: when the video is done, the timer should reflect the completed length of the video, and the Pause button should change back to a Play (or perhaps a Replay) button.

Observed behaviour: the Pause button stays and the timer disappears (see attached screenshot).

Observed on Inari build:
- gecko: b2g18:9cac5a5c4efb
- gaia: c51082d92f18c4c7cdbc4f96c977be735500562a

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Re: the asterisk in comment 0, you will need a number of patches to be able to play the STR video through to the end:
1. bug 863441 attachment 746396 [details] [diff] [review]
2. bug 864230 attachment 744257 [details] [diff] [review]
3. bug 877708 attachment 757784 [details] [diff] [review]

Patch 1 applies to gecko and landed some time ago; patch 2 applies to gonk and may need to be applied manually; patch 3 is still in testing.

Comment 2

[bhavana bajaj [:bajaj]]

Mike, is this a recent regression ?

Comment 3

[John Hammink]

This is fairly recent and I haven't seen this on older builds.  I'm not seeing it on other devices either (that I have checked so far).

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

I just reproduced this on Inari with:
- gecko: b2g18:09dc1ae3b1b5
- gaia: v1.0.1:37b6527c3f73a497f75d057e90386f77ff5a552b

In fact, I just noticed that the timer actually disappears long before we reach the end of the video. (Although with this particular build, I also notice that the Video app returns to the browser when the video finishes playing.)

Comment 5

[Peter Dolanjski [:pdol]]

Given the regression and the importance of the youtube experience, blocking.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

This video length is more then 1 hour, and the implementation shows nothing while length is more than a hour in https://github.com/mozilla-b2g/gaia/blob/1dbb4dbaa6c3022ff7bb30f891af28418e995eea/apps/video/js/view.js#L354. That's the reason you cannot find any timer information of the video.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: path for this bug

I did the following changes:
1. use the code of video.js to capture playerEnded and move the currentTime to 0
2. use the code of video.js to format time large than a hour.

Comment 8

[David Flanagan [:djf]]

Comment on attachment 761936 [details]
path for this bug

John,

The patch looks good to me. I'm assuming that you have tested it though.  

If so, then r=djf for github commit b2a0f11 

Once again, I need to apologize for creating a second independent copy of the video player code in the video app. It made sense at the time, but we've clearly let it get out of sync with the main copy and it is causing headaches.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:

https://github.com/mozilla-b2g/gaia/commit/9e582ada7046a0e2278ebbc8a0942537b0908520

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 9e582ada7046a0e2278ebbc8a0942537b0908520 to:
v1-train: 307c02068a21a79e655831666f69ef340cb23eed

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd 307c02068a21a79e655831666f69ef340cb23eed

Comment 12

[dkumar]

Varified,fixed on Leo Mozilla RIL.
Environmental Variables
Build ID: 20130716070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/629020cf576b
Gaia: fb9362d34260771d4a00b9a0e10a6bbad397bd3b
Platform Version: 18.1
RIL Version: 01.01.00.019.158

Issue resolved play and timer button appears