879404 - Use TimeStamp instead of PRTime in nsJSContext

Status: RESOLVED DUPLICATE of bug 1580883

(Core :: DOM: Core & HTML, defect, P5)

Description

[Andrew McCreight [:mccr8]]

Apparently PRTime doesn't guarantee monotonicity (ie that time always moves forward), so this can end up feeding negative durations for CCs to the profiler, which results in junky output.  I think TimeStamp doesn't have that problem, so we should convert to it, at least for the CC logging stuff.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1: use TimeStamp for script duration

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2: use it everywhere else in nsJSEnvironment.cpp

try run looked good https://tbpl.mozilla.org/?tree=Try&rev=b3bb655d7107

Comment 3

[Chris Peterson [:cpeterson]]

Andrew: are these TimeStamp patches still relevant for CC logging?

Comment 4

[Andrew McCreight [:mccr8]]

I've converted some of the uses of PRTime in another patch, but I guess we could still convert the rest.

Comment 5

[Andrew McCreight [:mccr8]]

One thing to watch out for here is the generation of the JSON for the GC takes a PRTime::Now() argument thing.  That probably needs to get converted to taking a time delta computed from TimeStamp in nsJSEnvironment.