Closed
Bug 879404
Opened 10 years ago
Closed 3 years ago
Use TimeStamp instead of PRTime in nsJSContext
Categories
(Core :: DOM: Core & HTML, defect, P5)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
DUPLICATE
of bug 1580883
People
(Reporter: mccr8, Unassigned)
Details
Attachments
(2 files)
8.84 KB,
patch
|
Details | Diff | Splinter Review | |
12.84 KB,
patch
|
Details | Diff | Splinter Review |
Apparently PRTime doesn't guarantee monotonicity (ie that time always moves forward), so this can end up feeding negative durations for CCs to the profiler, which results in junky output. I think TimeStamp doesn't have that problem, so we should convert to it, at least for the CC logging stuff.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → continuation
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
try run looked good https://tbpl.mozilla.org/?tree=Try&rev=b3bb655d7107
Comment 3•9 years ago
|
||
Andrew: are these TimeStamp patches still relevant for CC logging?
Flags: needinfo?(continuation)
Reporter | ||
Comment 4•9 years ago
|
||
I've converted some of the uses of PRTime in another patch, but I guess we could still convert the rest.
Flags: needinfo?(continuation)
Reporter | ||
Comment 5•9 years ago
|
||
One thing to watch out for here is the generation of the JSON for the GC takes a PRTime::Now() argument thing. That probably needs to get converted to taking a time delta computed from TimeStamp in nsJSEnvironment.
Reporter | ||
Updated•5 years ago
|
Assignee: continuation → nobody
Updated•5 years ago
|
Priority: -- → P5
Assignee | ||
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
Reporter | ||
Updated•3 years ago
|
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•