879406 - 'mach help debug' and 'mach help run' fail with ValueError: invalid option string u'+remote': must start with a character '-'

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Andrew McCreight [:mccr8]]

Error running mach:

    ['help', 'debug']

The error occurred in mach itself. This is likely a bug in mach itself or a
fundamental problem with a loaded module.

Please consider filing a bug against mach by going to the URL:

    https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=mach


If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ValueError: invalid option string u'+remote': must start with a character '-'

  File "/Users/amccreight/mz/cent2/python/mach/mach/main.py", line 259, in run
    return self._run(argv)
  File "/Users/amccreight/mz/cent2/python/mach/mach/main.py", line 297, in _run
    args = parser.parse_args(argv)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1688, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1720, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1929, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1885, in consume_positionals
    take_action(action, args)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1794, in take_action
    action(self, namespace, argument_values, option_string)
  File "/Users/amccreight/mz/cent2/python/mach/mach/dispatcher.py", line 86, in __call__
    self._handle_subcommand_help(parser, args[0])
  File "/Users/amccreight/mz/cent2/python/mach/mach/dispatcher.py", line 166, in _handle_subcommand_help
    group.add_argument(*arg[0], **arg[1])
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1267, in add_argument
    kwargs = self._get_optional_kwargs(*args, **kwargs)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1397, in _get_optional_kwargs
    raise ValueError(msg % tup)

Comment 1

[Gregory Szorc [:gps]]

Attachment: Unbust |mach help| when arguments are not prefixed with '-'

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 760946 [details] [diff] [review]
Unbust |mach help| when arguments are not prefixed with '-'

Review of attachment 760946 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mach/mach/dispatcher.py
@@ +184,5 @@
> +
> +        if handler.allow_all_arguments:
> +            parser_args['prefix_chars'] = '+'
> +
> +        c_parser = argparse.ArgumentParser(**parser_args)

Is it worth wrapping these lines up in a helper function instead of repeating them?

Comment 4

[Gregory Szorc [:gps]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> Is it worth wrapping these lines up in a helper function instead of
> repeating them?

Perhaps. But I'm lazy ATM :)

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/7d50de16dff8