879420 - [Calendar] Pressing 'enter' on the add account page will break calendar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Kevin Grandon :kgrandon]

Attachment: Screenshot illustrating issue

AFAIK this only happens when setting up a CalDav account. STR:

1 - Create a new CalDav account
2 - Tap on a field
3 - Press enter key on keyboard
4 - Be brought to a 404 page.

Attaching a screenshot of what I see on desktop (404 page is displayed slightly differently, but the effect is the same).

The user has to quit and reopen calendar for it to be working again, and loses any information entered. This can be pretty painful because CalDav URLs can be very long.

Comment 1

[Jason Smith [:jsmith]]

Confirmed on a 1.1 b2g18 device. I'm getting a file not found error page with an app:// on device.

Comment 2

[Jason Smith [:jsmith]]

Looks like this happens even when all fields are entered.

Hitting enter on a keyboard is a possible use case for a user as one form of submission of data. The fact that this sends us to a broken error page is a bad experience.

Comment 3

[Jason Smith [:jsmith]]

Actually, let's track here instead.

This also reproduces with yahoo add account UI.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 5

[James Lal [:lightsofapollo]]

in master: https://github.com/mozilla-b2g/gaia/commit/1d9f9cd48112f11781dea08d8be9d3950ba34069

We should uplift this...

Also- its likely that this issue also exists when creating events ?

Comment 6

[Jason Smith [:jsmith]]

(In reply to James Lal [:lightsofapollo] ( Back June 3rd ) from comment #5)
> in master:
> https://github.com/mozilla-b2g/gaia/commit/
> 1d9f9cd48112f11781dea08d8be9d3950ba34069
> 
> We should uplift this...
> 
> Also- its likely that this issue also exists when creating events ?

On 1.01 I didn't see this reproduce when creating events. Only saw this with the caldav/yahoo add account UIs.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Blocking, regression from v1.0.1

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 1d9f9cd48112f11781dea08d8be9d3950ba34069 to:
v1-train: ff7a7756e05d96ee58f375268ca6b124957e19f6

Comment 10

[Jason Smith [:jsmith]]

Verified on b2g18 on 6/17 by testing the add account pages for Yahoo & Caldav and ensuring that we do not get the broken UI when hitting the return key.