Closed Bug 879535 Opened 11 years ago Closed 11 years ago

Save and send tokens in `Reply-To` headers of reviewer emails

Categories

(Marketplace Graveyard :: Reviewer Tools, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
2013-08-13

People

(Reporter: cvan, Assigned: ashish_d)

References

Details

(Whiteboard: [qa-])

Generate a new token with an expiry for some time in the future. Use reasonable defaults for now (e.g., 30 days for reviewers, 60 days for developers).

When sending the email to the developer, include a `Reply-To` header containing that token (e.g., `Firefox Marketplace <reply+e98106f8-cd41-11e2-9172-14109fd8fe61@reply.mozilla.org>`)
Assignee: nobody → ashish.dubey91
Priority: -- → P2
Ashish is doing this right now.
Target Milestone: --- → 2013-06-27
Target Milestone: 2013-06-27 → 2013-07-04
https://github.com/mozilla/zamboni/blob/master/mkt/reviewers/utils.py#L36

Because each email needs a unique `Reply-To` token that corresponds to that particular user+thread combination, we need to send a separate email per recipient.
CC'ing reviewers that it's okay to send emails to individual reviewers instead of setting a `Reply-To` to the app-reviewers mailing list. This means that developers' responses will no longer get sent to the app-reviewers list but will instead get sent to the Communication Dashboard. When the Communication Dashboard receives a developer's response, if you have access to read the message, you will get an email notification *and* it will show up as unread in your Communication Dashboard.

Please confirm that this behaviour is acceptable.
Ashish, be sure to set a `Reply-To` token for super reviewers here: https://github.com/mozilla/zamboni/blob/master/mkt/reviewers/utils.py#L165
(In reply to Christopher Van Wiemeersch [:cvan] from comment #3)
> CC'ing reviewers that it's okay to send emails to individual reviewers
> instead of setting a `Reply-To` to the app-reviewers mailing list. This
> means that developers' responses will no longer get sent to the
> app-reviewers list but will instead get sent to the Communication Dashboard.
> When the Communication Dashboard receives a developer's response, if you
> have access to read the message, you will get an email notification *and* it
> will show up as unread in your Communication Dashboard.
> 
> Please confirm that this behaviour is acceptable.

I don't understand what we're being asked to confirm exactly.
Target Milestone: 2013-07-04 → 2013-07-11
Target Milestone: 2013-07-11 → 2013-07-18
Target Milestone: 2013-07-18 → 2013-07-25
https://github.com/mozilla/zamboni/pull/898
Target Milestone: 2013-07-25 → 2013-08-01
fixed https://github.com/mozilla/zamboni/commit/600e47
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: 2013-08-01 → 2013-08-13
Please add STR here or mark it with [qa-] if no QA is needed.
Flags: needinfo?(cvan)
Flags: needinfo?(cvan)
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.