879535 - Save and send tokens in `Reply-To` headers of reviewer emails

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

Generate a new token with an expiry for some time in the future. Use reasonable defaults for now (e.g., 30 days for reviewers, 60 days for developers).

When sending the email to the developer, include a `Reply-To` header containing that token (e.g., `Firefox Marketplace <[e-mail]>`)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Ashish is doing this right now.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/blob/master/mkt/reviewers/utils.py#L36

Because each email needs a unique `Reply-To` token that corresponds to that particular user+thread combination, we need to send a separate email per recipient.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

CC'ing reviewers that it's okay to send emails to individual reviewers instead of setting a `Reply-To` to the app-reviewers mailing list. This means that developers' responses will no longer get sent to the app-reviewers list but will instead get sent to the Communication Dashboard. When the Communication Dashboard receives a developer's response, if you have access to read the message, you will get an email notification *and* it will show up as unread in your Communication Dashboard.

Please confirm that this behaviour is acceptable.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Ashish, be sure to set a `Reply-To` token for super reviewers here: https://github.com/mozilla/zamboni/blob/master/mkt/reviewers/utils.py#L165

Comment 5

[Andrew Williamson [:eviljeff]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #3)
> CC'ing reviewers that it's okay to send emails to individual reviewers
> instead of setting a `Reply-To` to the app-reviewers mailing list. This
> means that developers' responses will no longer get sent to the
> app-reviewers list but will instead get sent to the Communication Dashboard.
> When the Communication Dashboard receives a developer's response, if you
> have access to read the message, you will get an email notification *and* it
> will show up as unread in your Communication Dashboard.
> 
> Please confirm that this behaviour is acceptable.

I don't understand what we're being asked to confirm exactly.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/pull/898

Comment 7

[Ashish Dubey [:ashish_d]]

fixed https://github.com/mozilla/zamboni/commit/600e47

Comment 8

[Iulian Timis]

Please add STR here or mark it with [qa-] if no QA is needed.