879582 - [Homescreen:Everything.me] User can't know that the more shortcut is exist because the vertical scroll is not shown.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P1)

Description

[Leo]

In Everything.me screen there is no vertical scroll. This is not good for UX scenario. How about adding a vertical scroll when more shorcuts are added?

Comment 1

[Eric O'Connor [:oconnore]]

Attachment: Pull request on github

I'm not sure who needs to review this.

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Eric, I would rather use this change instead
https://github.com/mozilla-b2g/gaia/pull/10576

Comment 3

[Eric O'Connor [:oconnore]]

Ah, that is better. I closed my PR: https://github.com/mozilla-b2g/gaia/pull/10563

Comment 4

[Dietrich Ayala (:dietrich)]

Thanks guys. Ran, does that PR need review and landing?

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR

Comment 6

[Ran Ben Aharon [:ranbena] EverythingMe]

Merged to master https://github.com/mozilla-b2g/gaia/commit/a137fc19ed8757f7451c872b3c4b839d4f46a8bd

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted a137fc19ed8757f7451c872b3c4b839d4f46a8bd to:
v1-train: e54eb0a05adb41f3b07214892aeca9a2a85a0b92

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: e54eb0a05adb41f3b07214892aeca9a2a85a0b92