Closed Bug 879611 Opened 8 years ago Closed 7 years ago

OS X tabstrip icons nearly invisible with dark LWT

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: Dolske, Assigned: Gijs)

References

Details

(Whiteboard: [Australis:M9][Australis:P2])

Attachments

(3 files)

(Filed from Australis tabs ui-review #1)

OSX + Dark LWT: The newtab icon and "list all tabs dropdown" icons are not visible. See right side of tabstrip:

 https://www.flickr.com/photos/12814025@N06/8952296982/in/set-72157633929895017/

Panorama and the native fullscreen-window control have the same issue.

(Also, what's up with the system menubar in that screenshot?)
Flags: needinfo?(mnoorenberghe+bmo)
(In reply to Justin Dolske [:Dolske] from comment #0)
> (Also, what's up with the system menubar in that screenshot?)

That seemed to happen recently around the time I was automating the screenshots. I just restarted the computer so we'll see if it comes back.  My guess would be an OS X bug related to going into and out of Lion fullscreen repeatedly.
Flags: needinfo?(mnoorenberghe+bmo)
Hardware: x86 → All
Not taking this for M7. Is this not an issue on current nightly?
Whiteboard: [Australis:M?] → [Australis:M?][Australis:P2]
AFAICT this needs inverted icons (newtab-inverted.png; newtab-inverted@2x.png) on OS X, which we do seem to have on Windows but not OS X? Needinfo'ing Stephen to confirm and get us icons for this... :-)
Flags: needinfo?(shorlander)
(ditto for alltabs-box-bkgnd-icon[-lion[@2px]].png and tab-arrow-(left|right)[@2x].png )
Assignee: nobody → shorlander
I should be able to get to this later today...
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
I don't even like black themes, but I have to say, this looks pretty slick. :-)
Attachment #795418 - Flags: review?(mnoorenberghe+bmo)
it DOES look pretty slick! <3
Comment on attachment 795418 [details] [diff] [review]
OS X tabstrip icons should have inverted versions for dark LWTs,

Review of attachment 795418 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming alltabs-box-bkgnd-icon-inverted* looks fine on all supported OS X versions. Sorry for the delay.

::: browser/themes/osx/jar.mn
@@ +196,5 @@
>    skin/classic/browser/social/chat-icons.png                             (social/chat-icons.png)
>    skin/classic/browser/social/chat-icons@2x.png                          (social/chat-icons@2x.png)
>    skin/classic/browser/tabbrowser/alltabs-box-bkgnd-icon.png             (tabbrowser/alltabs-box-bkgnd-icon.png)
> +  skin/classic/browser/tabbrowser/alltabs-box-bkgnd-icon-inverted.png    (tabbrowser/alltabs-box-bkgnd-icon-inverted.png)
> +  skin/classic/browser/tabbrowser/alltabs-box-bkgnd-icon-inverted@2x.png (tabbrowser/alltabs-box-bkgnd-icon-inverted@2x.png)

Was it decided to use the same inverted icon on the lions and Snow Leopard? You mention the lion files in comment 4 but I don't see a confirmation on the bug that the omission was intentional. Can you double-check with Stephen? It's probably fine since we don't have other lion-specific inverted images in this file.

@@ +211,5 @@
>    skin/classic/browser/tabbrowser/tab-arrow-left.png                     (tabbrowser/tab-arrow-left.png)
>    skin/classic/browser/tabbrowser/tab-arrow-left@2x.png                  (tabbrowser/tab-arrow-left@2x.png)
>    skin/classic/browser/tabbrowser/tab-arrow-right.png                    (tabbrowser/tab-arrow-right.png)
>    skin/classic/browser/tabbrowser/tab-arrow-right@2x.png                 (tabbrowser/tab-arrow-right@2x.png)
> +  skin/classic/browser/tabbrowser/tab-arrow-left-inverted.png            (tabbrowser/tab-arrow-left-inverted.png)

Nit: move the "-left" above the "-right" so the left are all together.
Attachment #795418 - Flags: review?(mnoorenberghe+bmo) → review+
(In reply to Matthew N. [:MattN] from comment #10)
> Was it decided to use the same inverted icon on the lions and Snow Leopard?
> You mention the lion files in comment 4 but I don't see a confirmation on
> the bug that the omission was intentional. Can you double-check with
> Stephen? It's probably fine since we don't have other lion-specific inverted
> images in this file.

There isn't actually a separate lion Toolbar.png image anymore. There's just one. See:

https://bugzilla.mozilla.org/show_bug.cgi?id=875488#c12
(In reply to Stephen Horlander [:shorlander] from comment #12)
> (In reply to :Gijs Kruitbosch from comment #11)
> > (In reply to :Gijs Kruitbosch from comment #10)
> > > For OSX, will we use the same images everywhere? In the previous
> > > incarnation, we had separate sprites for (Mountain) Lion.
> > 
> > To clarify "previous incarnation": our current OSX theme has a
> > Toolbar-Lion.png (and an @2x version).
> 
> I would like to move to just one style for OS X. Lion was released almost
> two years ago, I am ok with back-porting a little of that to Snow Leopard.

Some part of me thinks we may want to unify this to only use the lion imagery everywhere for consistency (ie, get rid of the '-lion' part of all filenames, remove all the lion specific includes etc.). But that'd be a separate bug.

Anyway, needinfo'ing for the question of what we want to do here and/or for the general case, just to confirm... Stephen, can you clarify your intentions? :-)
Flags: needinfo?(shorlander)
I clarified the Lion question with Stephen over IRC, we're good to go here when the tree is green.
Flags: needinfo?(shorlander)
Pushed with nit fixed: https://hg.mozilla.org/projects/ux/rev/eec7f37f7d38
Whiteboard: [Australis:M?][Australis:P2] → [Australis:M9][Australis:P2][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/eec7f37f7d38
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P2][fixed-in-ux] → [Australis:M9][Australis:P2]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.