879649 - Add cx push back to nsJSContext::CompileScript

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

I added a patch to properly push a cx, but we had to do a spot backout in bug 875790 because of firebug crashes.

I haven't been able to reproduce it, either on macosx64 or linux64. Alice can reproduce it on linux32, so presumably it's a 32-bit issue. Unfortunately, my 32 bit ubuntu VM won't compile gecko anymore (it OOMs during link).

So I'm going to do a try push to generate builds that way.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=03b6d8306a73

Comment 2

[Octoploid]

(In reply to Bobby Holley (:bholley) from comment #0)
> 
> I haven't been able to reproduce it, either on macosx64 or linux64. Alice
> can reproduce it on linux32, so presumably it's a 32-bit issue.
> Unfortunately, my 32 bit ubuntu VM won't compile gecko anymore (it OOMs
> during link).

I'm running x86_64, so it's not a 32-bit only issue. See also:
https://crash-stats.mozilla.com/report/list?signature=js%3A%3ACloneScript%28JSContext*%2C+JS%3A%3AHandle%3CJSObject*%3E%2C+JS%3A%3AHandle%3CJSFunction*%3E%2C+JS%3A%3AHandle%3CJSScript*%3E%2C+js%3A%3ANewObjectKind%29

Comment 3

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8508340fabb7

Comment 4

[Bobby Holley (:bholley)]

I accidentally landed this with the bug number of bug 875790

Comment 5

[Scoobidiver (away)]

https://hg.mozilla.org/mozilla-central/rev/8508340fabb7