Closed
Bug 879661
Opened 12 years ago
Closed 12 years ago
Unit test of internet_sharing.js failed frequently.
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
Details
Attachments
(1 file)
Unit test of internet_sharing.js in travis seems always failed.
https://travis-ci.org/mozilla-b2g/gaia/builds/7782466
https://travis-ci.org/mozilla-b2g/gaia/builds/7780064
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → johu
Assignee | ||
Comment 1•12 years ago
|
||
This is caused by two problem:
1. The mock implementation of mozMobileConnection can't handle addEventListener('type', [object Object]);
1. The init function of mock implementation of mozMobileConnection doesn't clear the event listeners added before, in statusbar_test.js.
Assignee | ||
Comment 2•12 years ago
|
||
Change the implementation of mock object of mozMobileConnection
passed log with this pr:
https://travis-ci.org/mozilla-b2g/gaia/builds/7798701
https://travis-ci.org/mozilla-b2g/gaia/builds/7799017
https://travis-ci.org/mozilla-b2g/gaia/builds/7799623
Attachment #758464 -
Flags: review?(alive)
Assignee | ||
Comment 3•12 years ago
|
||
This bug fixes the unit test failures introduced by Bug 868902.
Updated•12 years ago
|
Attachment #758464 -
Flags: review?(alive) → review+
Assignee | ||
Comment 4•12 years ago
|
||
merged to master.
https://github.com/mozilla-b2g/gaia/commit/12fa5f96786697ef348518b897fcf3b580b0b117
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•