pasting in URL to document window should add URL to urlbar history

RESOLVED FIXED in Future

Status

()

Core
History: Global
RESOLVED FIXED
17 years ago
13 years ago

People

(Reporter: Jeremy M. Dolan, Assigned: wolfiR)

Tracking

Trunk
Future
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 4 obsolete attachments)

(Reporter)

Description

17 years ago
A very handy Nav feature on UNIX, middleclicking to paste a URL into the
document part of the window, but this should add the URL to the location bar
history, since the middle click is really just a short cut for going to the
location bar, clearing it, and then pasting.

In netscape 4 I *OFTEN* found myself trying to find a site in the location bar
history, only to remember that I had used the middle-click method to access it,
and I had to dig through 1000s of pages in the generic History to find it again.

Comment 1

17 years ago
a good idea... eventually we'll be merging global and urlbar history, and
flagging certain global history entries as "entered on the url bar"
Status: NEW → ASSIGNED
Summary: pasting in URL to document window should add URL to location dropdown → pasting in URL to document window should add URL to urlbar history
Target Milestone: --- → Future

Comment 2

17 years ago
reassigning history bugs to new owner - send this bug back to me if it looks
like something I should fix (such as embedding-related architecture issues),
rather than the actual history owner...
Assignee: alecf → blakeross
Status: ASSIGNED → NEW
Target Milestone: Future → ---
(Reporter)

Comment 3

17 years ago
3-month ping.

Did they get merged yet? Still keep losing stuff I pasted in... annoying.

Updated

17 years ago
Target Milestone: --- → mozilla1.2

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: mozilla1.2 → Future

Comment 4

16 years ago
Created attachment 69353 [details] [diff] [review]
patch (untested)
(Reporter)

Comment 5

16 years ago
Patch doesn't seem to do anything. No JS error, no history entry.
(Assignee)

Comment 6

13 years ago
Created attachment 187770 [details] [diff] [review]
FF patch
(Assignee)

Updated

13 years ago
Assignee: firefox → mozilla
Status: ASSIGNED → NEW
(Assignee)

Comment 7

13 years ago
Created attachment 187919 [details] [diff] [review]
improved FF patch
Attachment #187770 - Attachment is obsolete: true
Attachment #187919 - Flags: review?(mconnor)
Comment on attachment 187919 [details] [diff] [review]
improved FF patch

>+# vim:set ts=2 sw=2 sts=2 et:

we don't add vim modelines, its evil or something

>-function addToUrlbarHistory()
>+function addToUrlbarHistory( aUrlToAdd )

drop the spaces around the arg, please.

>+  try {
>+    addToUrlbarHistory(url);
>+  } catch (ex) {
>+    // Things may go wrong when adding url to session history,
>+    // but don't let that interfere with the loading of the url.
>+  }
>+

the try/catch bits in addToUrlbarHistory() should already catch the likely
failures, but the other caller wraps the call too.  Seems like overkill, but
I'm not going to worry about it at this point.
Attachment #187919 - Flags: review?(mconnor) → review+
(Assignee)

Comment 9

13 years ago
Created attachment 187920 [details] [diff] [review]
patch with integrated review comments
Attachment #187920 - Flags: approval-aviary1.1a2?
(Assignee)

Comment 10

13 years ago
Created attachment 187921 [details] [diff] [review]
seamonkey patch
(Assignee)

Comment 11

13 years ago
Created attachment 187923 [details] [diff] [review]
seamonkey patch #2

urlbar history handling is rather different from FF.
Attachment #187921 - Attachment is obsolete: true

Comment 12

13 years ago
Comment on attachment 187923 [details] [diff] [review]
seamonkey patch #2

Unfortunately you can't make contentAreaClick.js depend on sessionHistoryUI.js
because it's used by components other than navigator.
(Assignee)

Comment 13

13 years ago
Created attachment 188099 [details] [diff] [review]
seamonkey #3

then I think this is the only possible way?
Attachment #187923 - Attachment is obsolete: true
Attachment #188099 - Flags: review?(neil.parkwaycc.co.uk)

Comment 14

13 years ago
Comment on attachment 188099 [details] [diff] [review]
seamonkey #3

OK, but you should remove the sessionHistoryUI.js version and fix up its
callers. Also you should add the url before the call to getShortcutOrURI
because that's the way the other callers do it.
Attachment #188099 - Flags: review?(neil.parkwaycc.co.uk) → review-
(Assignee)

Comment 15

13 years ago
Created attachment 188218 [details] [diff] [review]
seamonkey #4

this patch moves the addToUrlbarHistory() function to
communicator/contentAreaClick.js and use the URL as argument.
Attachment #188099 - Attachment is obsolete: true
Attachment #188218 - Flags: review?(neil.parkwaycc.co.uk)

Updated

13 years ago
Attachment #187920 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+

Updated

13 years ago
Attachment #188218 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Comment 17

13 years ago
Comment on attachment 188218 [details] [diff] [review]
seamonkey #4

not really sure if sr is needed but Neil is an sr for the case.
This patch is seamonkey only stuff.
Attachment #188218 - Flags: approval1.8b3?

Updated

13 years ago
Attachment #188218 - Flags: approval1.8b3? → approval1.8b4+
(Assignee)

Comment 18

13 years ago
Checking in browser/resources/content/navigator.js;
/cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v  <--  navigator.js
new revision: 1.573; previous revision: 1.572
done
Checking in browser/resources/content/navigator.xul;
/cvsroot/mozilla/xpfe/browser/resources/content/navigator.xul,v  <--  navigator.xul
new revision: 1.431; previous revision: 1.430
done
Checking in browser/resources/content/sessionHistoryUI.js;
/cvsroot/mozilla/xpfe/browser/resources/content/sessionHistoryUI.js,v  <-- 
sessionHistoryUI.js
new revision: 1.54; previous revision: 1.53
done
Checking in communicator/resources/content/contentAreaClick.js;
/cvsroot/mozilla/xpfe/communicator/resources/content/contentAreaClick.js,v  <--
 contentAreaClick.js
new revision: 1.48; previous revision: 1.47
done
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.