879694 - (mmi-localization-cb) [MMI] Localization of Call Barring functionality.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[bov]

Steps    
- Settings, Language, Set to any language except english    
- Open Dialer App, type "*33*XXXX#" (where XXXX is a four digits password), and click on the green dialer button.

Actual Result:

Tested on Unagi device. Build :Gecko-52341e4.Gaia-71c3bcd CommRIL:AU105
Result:"Call barring generic failure"
Tested on Unagi device. Build :Gecko-80fd2ae.Gaia-0a1cf9f CommRIL:AU115
Result:"CALL_BARRING_NOT_SUPPORTED_VIA_MMI"

Expected Result:
The error message should be shown in the selected language in Settings

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

These look like issues partners will care about having fixed for releasing in target markets - Michael seems related to 879032 - thoughts?

Comment 2

[David Scravaglieri [:scravag]]

Partner think it's a blocker

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Carol, since we don't have Call Barring support in the reference implementation, could you please send me an example of successful and error reply with the commercial RIL (once it implements MMIResult and MMIError) so I can adjust the Gaia side? Thanks!

Comment 5

[Carol Yang [:cyang]]

(In reply to Fernando Jiménez Moreno [:ferjm] (needinfo instead of CC, please) from comment #4)
> Carol, since we don't have Call Barring support in the reference
> implementation, could you please send me an example of successful and error
> reply with the commercial RIL (once it implements MMIResult and MMIError) so
> I can adjust the Gaia side? Thanks!

Hi Fernando, these are some examples of what I intend on sending. Let me know if you expect something different.

Success case for querying when service is disabled:
{
  requestId : 'id{07db922e-b856-4248-8909-165a8ddc3bc4}',
  mmiServiceCode : 'scCallBarring',
  result : 'smServiceDisabled'
}

Success case for querying when service is enabled. Note the need for additional info to list out the service class that the service has been enabled for:
{
  requestId : 'id{07db922e-b856-4248-8909-165a8ddc3bc4}',
  mmiServiceCode : 'scCallBarring',
  result : 'smServiceEnabledFor',
  serviceClass: ['serviceClassVoice', 'serviceClassData']
}

Error case:
{
  requestId : 'id{4b3d24e6-d93f-461e-9c3f-9b91bf6dc10b}',
  mmiServiceCode : 'scCallBarring',
  errorMsg : 'GenericFailure'
}

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

The string change was suggested in bug 888193

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 768844 [details] [diff] [review]
v1

Review of attachment 768844 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/a82bd42efd76cbee5bdca741eeb691d5ebc7c9f6

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Uplifted a82bd42efd76cbee5bdca741eeb691d5ebc7c9f6 to:
v1-train: f9116efb2e8b0231f24eb0760b348a5a8df38b02

Comment 11

[Gareth Aye [:gaye] (back from PTO)]

v1.1.0hd: f9116efb2e8b0231f24eb0760b348a5a8df38b02

Comment 12

[Carol Yang [:cyang]]

Hi Fernando, 

There's a bug with this patch: 'additionalInfo' is being referenced instead of 'additionalInformation' which is causing an error:

GeckoConsole: [JavaScript Error: "ReferenceError: additionalInfo is not defined" {file: "app://communications.gaiamobile.org/dialer/js/mmi.js" line: 181}]

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

Thanks Carol! The fix is in Bug 890291

Comment 15

[Cody Roesch [:croesch]]

Verified that the message Call Barring and Generic Failure are translated in all the languages below. However we have no further information on if Generic Failure is the intended message or not. If not the intended message then please provide information on how to get the message you need checked.

Verified on Leo 1.1 build with the following variables:

Environmental Variables
Build ID: 20130814041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/15813d776a69
Gaia: dd3959fa74e356a528daa76ffee14c2c728a4b56
Platform Version: 18.1
RIL Version: 01.01.00.019.190

Following languages verified:
Polish, Czech,Dutch, Russian, Greek, Slovak, Romanian,Brazilian Portuguese, Hungarian, German, Spanish, Turkish, Croatian, Serbian, Catalan, Serbian-Latin