879696 - [regression] Bug 872054 causes the dtmf tone output through speaker when earphone is plugged.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

As title,
the bug's patch set the tone's channel to 'ringer' when it is not during call.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/10213

Change the tone channel to normal.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Note: the patch is toward v1.0.1

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 758476 [details]
https://github.com/mozilla-b2g/gaia/pull/10213

Looks good, and doesn't regress bug 872054.

Thanks!

Comment 4

[Daniel Coloma:dcoloma]

is the status for 1.0.1 ok?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

v1.0.1 merged.
https://github.com/mozilla-b2g/gaia/commit/37b6527c3f73a497f75d057e90386f77ff5a552b

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Alive Kuo [:alive] from comment #5)
> v1.0.1 merged.
> https://github.com/mozilla-b2g/gaia/commit/
> 37b6527c3f73a497f75d057e90386f77ff5a552b

Can you please land this on v1-train if it's applicable there?

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

v1-train
https://github.com/mozilla-b2g/gaia/commit/776dd114d5a61a7542a7f7ed786f08fa45c1b4af

master
https://github.com/mozilla-b2g/gaia/commit/e00fb71e5fbd3a09ad4f491e02c4e6184cd403e9

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 776dd114d5a61a7542a7f7ed786f08fa45c1b4af