Closed Bug 879701 Opened 11 years ago Closed 11 years ago

IonMonkey: Split up the used/bound assertion in ARM CodeGenerator

Categories

(Core :: JavaScript Engine, defect)

ARM
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: decoder, Assigned: decoder)

Details

(Keywords: sec-want)

Attachments

(1 file)

Attached patch PatchSplinter Review
In bug 829534, Nicolas already mentioned that this assertion

"Assertion failure: label->used() && !label->bound(), at ion/arm/CodeGenerator-arm.cpp"

can have two different implications, depending on which of the conditions is triggering it. While one is harmless, the other might indicate a security bug. The suggestion was to split them up into two assertions, which is what the attached patch does.
Attachment #758472 - Flags: review?(mrosenberg)
Attachment #758472 - Flags: review?(mrosenberg) → review+
https://hg.mozilla.org/mozilla-central/rev/0d65b1c05b2f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: