879770 - Each time mobile data is enabled, usage statistics increase more than expected for controlled reasons, surpassing statistics reported by Gonk.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Salvador de la Puente González [:salva]]

STR:

It is easy if you try from a fresh flashed device, after rebooting. In an unique SIM environment.

1- Pass the FTE of Cost Control
2- Open the utility tray and observe data usage
3- Enter in the device and show contents for /proc/net/dev:
adb shell
cat /proc/net/dev

Data usage is normally split in transmitted and received bytes and the name of the mobile interface is rmnet0 on Unagui devices.

Expected:
Value observed in Usage application coincides or is near (but never greater) than the value reported by Gonk.

Actual:
Value observed in Usage application is greater than those reported by Gonk.

Comment 1

[Albert [:albert]]

The problem occurs when the interface is down (shutdown WIFI or 3G) and, in someway, a request to the API is done for that interface. When the API receives a request for interface 'x' it update the stats for the iface and then get stats from the DB.

When updating the stats, as the interface is down, the network manager returns that the iface is not available, so the networkstats update the stats hardcoding txTotalBytes and rxTotalBytes to 0. As a result the real counter of rx and tx is lost, updated to 0 and the computed rx / tx is rx - 0 instead of rx - rx.

Comment 2

[Albert [:albert]]

Attachment: Fix update stats error when iface is down

Comment 3

[Gene Lian (I already quit Mozilla)]

I'm looking into this patch and will directly land them if it's OK. Please stay tuned.

Comment 4

[Gene Lian (I already quit Mozilla)]

Comment on attachment 758592 [details] [diff] [review]
Fix update stats error when iface is down

Since it's a super urgent issue, I'm directly landing them to all the needed branches. Give me 30 minutes. Thanks!

Comment 5

[Gene Lian (I already quit Mozilla)]

I also fixed some minor nits.

https://hg.mozilla.org/projects/birch/rev/953b1e4c5c17
https://hg.mozilla.org/releases/mozilla-b2g18/rev/bdeec7685714
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e329fbd2d2ed

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/953b1e4c5c17

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/bdeec7685714

Comment 8

[Jeni]

verified fixed on 
Unagi Build ID: 20130620230208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a34f6d62cb05
Gaia: de211a86e1df621415942e8b02acea77efafd864
Platform Version: 18.0

Value observed in Usage application of cost control coincides or is near than the value reported by Gonk.