Closed
Bug 87981
Opened 23 years ago
Closed 23 years ago
form controls shouldn't be 'vertical-align: bottom'
Categories
(Core :: Layout: Form Controls, defect, P1)
Core
Layout: Form Controls
Tracking
()
VERIFIED
FIXED
mozilla0.9.3
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(4 files)
217 bytes,
text/html
|
Details | |
4.62 KB,
patch
|
Details | Diff | Splinter Review | |
4.62 KB,
text/html
|
Details | |
1.47 KB,
patch
|
Details | Diff | Splinter Review |
Many of the form controls have 'vertical-align: bottom'. 'bottom' and 'top' are relative to the line itself rather than to the parent of the element, and they shouldn't be used for form controls. I'll attach a testcase that vividly demonstrates why (the text input is well below the rest of the line of text). Reasonable possibilities for form controls would probably be 'middle', 'baseline' (especially if they did 'baseline' correctly), or 'text-bottom'. I'd have to dig into what 4.x did and what IE does.
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
FWIW, I ran into this while investigating bug 78066, which would be fixed by fixing this.
Assignee | ||
Comment 3•23 years ago
|
||
This actually dates back to back when we had native form controls. ua.css: revision 3.5 date: 1998/05/07 00:06:15; author: kipp; state: Exp; lines: +10 -1 Updated style sheet
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
Assignee | ||
Comment 6•23 years ago
|
||
WinIE 5.5 does 'baseline' alignment (with a slightly offset baseline) MacIE 5.0 does 'text-bottom' alignment Netscape 4.x does something between 'baseline' and 'text-bottom' (it's hard to tell since it doesn't support 'vertical-align' -- It's basically exactly 'baseline' on Linux and closer to 'text-bottom' on Windows, with Mac somewhere in between)
Assignee | ||
Comment 7•23 years ago
|
||
Because I'm a bit worried about baseline doing weird things in Mozilla and because what it does in Mozilla isn't really 'baseline', I think 'text-bottom' would be the best choice for now, until we have 'baseline' working correctly. I'll attach a patch to switch form controls to 'baseline'. I think we might want to get this in to the branch to fix bug 78066.
Assignee | ||
Comment 8•23 years ago
|
||
Assignee | ||
Comment 9•23 years ago
|
||
Taking this, since I think it's our best chance to fix bug 78066 for RTM.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Comment 10•23 years ago
|
||
[s]r=waterson
Comment 11•23 years ago
|
||
r=attinasi
Assignee | ||
Comment 12•23 years ago
|
||
Checked in fix to trunk on 2001-07-12 22:19 PDT. Depending on whether there are any problems we might want to get this on the branch. I should also file a bug on making us use baseline alignment for some of the controls.
Assignee | ||
Comment 13•23 years ago
|
||
OK, this has missed the train for the branch.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 14•23 years ago
|
||
verified build: 20010724B &20010730T os:win98/mac8.6/Linux7
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•