form controls shouldn't be 'vertical-align: bottom'

VERIFIED FIXED in mozilla0.9.3

Status

()

Core
Layout: Form Controls
P1
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla0.9.3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Many of the form controls have 'vertical-align: bottom'.  'bottom' and 'top' are
relative to the line itself rather than to the parent of the element, and they
shouldn't be used for form controls.  I'll attach a testcase that vividly
demonstrates why (the text input is well below the rest of the line of text).

Reasonable possibilities for form controls would probably be 'middle',
'baseline' (especially if they did 'baseline' correctly), or 'text-bottom'.  I'd
have to dig into what 4.x did and what IE does.
Created attachment 40249 [details]
testcase showing why 'vertical-align: bottom' form controls are bad
FWIW, I ran into this while investigating bug 78066, which would be fixed by
fixing this.
This actually dates back to back when we had native form controls.

ua.css:
revision 3.5
date: 1998/05/07 00:06:15;  author: kipp;  state: Exp;  lines: +10 -1
Updated style sheet
Created attachment 40431 [details] [diff] [review]
testcase to determine behavior of other browsers
Created attachment 40432 [details]
testcase to determine behavior of other browsers
WinIE 5.5 does 'baseline' alignment (with a slightly offset baseline)
MacIE 5.0 does 'text-bottom' alignment
Netscape 4.x does something between 'baseline' and 'text-bottom' (it's hard to
  tell since it doesn't support 'vertical-align' -- It's basically
  exactly 'baseline' on Linux and closer to 'text-bottom' on Windows, with Mac
  somewhere in between)
Because I'm a bit worried about baseline doing weird things in Mozilla and
because what it does in Mozilla isn't really 'baseline', I think 'text-bottom'
would be the best choice for now, until we have 'baseline' working correctly. 
I'll attach a patch to switch form controls to 'baseline'.  I think we might
want to get this in to the branch to fix bug 78066.
Created attachment 40434 [details] [diff] [review]
patch to forms.css (is this the right set of changes?)
Taking this, since I think it's our best chance to fix bug 78066 for RTM.
Assignee: rods → dbaron
Keywords: nsBranch
Priority: -- → P1
Target Milestone: --- → mozilla0.9.3
Status: NEW → ASSIGNED

Comment 10

17 years ago
[s]r=waterson

Comment 11

17 years ago
r=attinasi
Checked in fix to trunk on 2001-07-12 22:19 PDT.  Depending on whether there are
any problems we might want to get this on the branch.  I should also file a bug
on making us use baseline alignment for some of the controls.

Updated

17 years ago
Blocks: 74865
OK, this has missed the train for the branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 14

17 years ago
verified build: 20010724B &20010730T os:win98/mac8.6/Linux7
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.