Weird title when going to http://www.libpng.org/pub/mng/mngpics.html

VERIFIED FIXED in mozilla0.9.3

Status

()

Core
Internationalization
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Henrik Gemal, Assigned: Frank Tang)

Tracking

({intl})

Trunk
mozilla0.9.3
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: nsbranch+,pdt+, URL)

Attachments

(3 attachments)

(Reporter)

Description

17 years ago
If you go to:
http://www.libpng.org/pub/mng/mngpics.html
a dialog comes up asking you to download some Japanese Fonts.
The Title of the dialog is really weird: "XD[]m"
properly japanese chars...

build 20010626

Comment 1

17 years ago
I don't see this
same build.
(Reporter)

Comment 2

17 years ago
do you use win2k?

Comment 3

17 years ago
Linux works fine. I compiled utf8 in my kernel and no problems (This page HAS
japanese fonts!)
I dont think this is a bug. Use IE and it should request you to download the
japanese codeset too
I would mark this one as invalid
(Reporter)

Comment 4

17 years ago
please read the bug! This bug is about the weird title. You cant have a dialog 
with a title that says "XD[]m"

Comment 5

17 years ago
Please attach a screenshot
(Reporter)

Comment 6

17 years ago
Created attachment 40290 [details]
screen shot of dialog that comes up on my Win2k box

Comment 7

17 years ago
http://www.sony.co.jp/
Go there (or any japanese website) and tell me if you get the same exact title
in the download font window
(Reporter)

Comment 8

17 years ago
almost. Same dialog, just different title. But still some japanese chars.

Comment 9

17 years ago
Reassign to yokoyama.
Assignee: nhotta → yokoyama

Comment 10

17 years ago
That maybe confirms my theory that those weird titles you are getting are no
more than the actual title of the webpage trying to be rendered by your normal
font. So until you install the japanese chars you wont get it fixed, but then if
you download them you wont have that window to start with :)

The problem? The title of that new window should be something like "Extra
Component Needed" instead of the actual webpage title
So the fix should be really simple, as described above

Comment 11

17 years ago
Switching QA contact to teruko for now.
QA Contact: andreasb → teruko

Comment 12

17 years ago
Code to bring up the dlgbox doesn't contain the title.
[/source/intl/locale/src/nsFontPackageHandler.cpp]
72 rv = windowWatch->OpenWindow(nsnull, absUrl, 
73    "_blank",
74    "chrome,centerscreen,titlebar,resizable", 
75    nsnull, 
76    getter_AddRefs(dialog));


May be ftang can shed a light on this bug.
assigning to ftang.
Assignee: yokoyama → ftang

Comment 13

17 years ago
I tried this with 2001062606.0.9.2 build on Winnt 4.0US.

The title of this dialog is shown in the different websites.
Even though I visited the same website several times, the title is not the same
at each time.

Website                               Title of font download dialog
-------------------------------------------------------------------
www.sony.co.jp                        /skin/scrollbar/btn-up.gif
home.netscape.com/ja                  no title
home.netscape.com/ja                  /skin/scrollbar/btn-up.gif
home.netscape.com/ko                  f
home.netscape.com/zh/cn               global
home.netscape.com/zh/tw               no title
www.yahoo.co.jp                       v
www.libpng.org/pub/mng/mngpics.html   1
www.zdnet.co.jp                       no title
www.yahoo.co.jp                       garbage title - I will attach the dialog
Keywords: intl

Comment 14

17 years ago
Created attachment 40306 [details]
screen shot on Winnt 4.0US

Comment 15

17 years ago
Maybe check what variable holds responsible for the title of that window, it
seems to be pointing to garbage, and check what function calls that new window
and replace that variable with plain text 
(Reporter)

Comment 16

17 years ago
Could someone also tell me where the text for the dialog is located? I cant seem 
to find it via lxr...

Comment 17

17 years ago
check out :
/xpfe/global/resources/locale/en-US/region.properties
fontDownloadURL=http://www.mozilla.org/projects/intl/fonts/win/en/package_%1$s.html

if Japanese, then the URL will be ...../package_ja.html
if Korean, then ...../package_ko.html

(Assignee)

Comment 18

17 years ago
there are two problems. First of all, we pass null string to set the title
second, in window, when we set the title to be null string, we display garbage.
Target Milestone: --- → mozilla0.9.3
(Assignee)

Comment 19

17 years ago
Created attachment 40385 [details] [diff] [review]
patch for the 2nd problem
(Assignee)

Comment 20

17 years ago
I still don't know why the window title= does not pass down to 
nsWindow::SetTitle
(Assignee)

Comment 21

17 years ago
mark as nsbranch
yokoyama- can you code review this one?
Status: NEW → ASSIGNED
Keywords: nsBranch

Comment 22

17 years ago
/r=yokoyama for 06/27/01 17:54
(Assignee)

Updated

17 years ago
Whiteboard: r=yokoyama need sr=

Comment 23

17 years ago
sr=alecf
(Assignee)

Comment 24

17 years ago
yokoyama land to trunk last night add vtrunk
Keywords: vtrunk
(Assignee)

Comment 25

17 years ago
mark it vtrunk+, this fix should be harmless. The only possible effect is to
null terminate it at 0, which is right. 
Whiteboard: r=yokoyama need sr= → vtrunk+

Comment 26

17 years ago
I checked it on 07-03-11 trunk build:
All those garbled characters in title bar are gone.  There is nothing showing there right now.
And I find another problem is seems auto-detect doesn't detect correctly with Netscape-Korean, Chinese, then this download dialog won't appear.  I'll file another for that later.  

Comment 27

17 years ago
I forgot to mention:
The font download dialog will appears behind the browser when you visit a page 
that doesn't has the correct font. 
Actually I just checked it on Marina's Win2k machine - 
has Japanese font but Korean and Chinese.  
We checked it on http://kr.yahoo.com, seems the font download dialog appears 
a very quick moment and then disappear - not even behind any windows.

So, I guess it still not work well for Win2k. 
(Assignee)

Comment 28

17 years ago
>So, I guess it still not work well for Win2k. 
We don't popup font download because the package cannot be install on win2k
in turn of this bug, it is fixed. Please file seperate bug for seperate problem. 
We don't show weired title anymore. 
Whiteboard: vtrunk+ → nsbranch+

Comment 29

17 years ago
Frank, won't it be a better solution for Win2K to pop up a dlgbox suggesting to
use a CD for font download... otherwise it's very confusing for the user..Font
dlgbox pops-up for a second and gives your an impression that something is wrong.

Comment 30

17 years ago
Bug 87945 is talking about the warning dialog for Win2k. 

Comment 31

17 years ago
the fix supposed to be in the trunk ( the bug 87945 is marked as fixed) and i
didn't see the font dlgbox coming up on Win2K in the 07-03-04 trunk build...as a
matter of fact Frank says > We don't popup font download because the package
cannot be install on win2k in turn of this bug, it is fixed> in his comments dated 
 2001-07-05 10:16 

Comment 32

17 years ago
The original bug is fixed in 7-5-06 Win32 trunk build on Winnt 4.0 US.  
(Assignee)

Comment 33

17 years ago
pdt+ per pdt meting. Land it today

marina- this bug is for garbage in the title. Please file seperate bug for other 
issue. Thanks
Whiteboard: nsbranch+ → nsbranch+,pdt+
(Assignee)

Comment 34

17 years ago
fixed check in to m92.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Updated

17 years ago
Keywords: vtrunk → vbranch

Comment 35

17 years ago
Verified as fixed in 7-13-0.9.2 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.