gfx/tests/Makefile.in - commented CMMSRCS=

RESOLVED FIXED in mozilla24

Status

Firefox Build System
General
RESOLVED FIXED
5 years ago
3 months ago

People

(Reporter: joey, Assigned: BenWa)

Tracking

unspecified
mozilla24
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
gfx/tests/Makefile.in

Commented entries in the makefile will need to be cleaned up/purged or re-enabled.

changeset:   70003:8e846d7f21ea
date:        Mon May 23 18:54:47 2011 +0200
summary:     Bug 648911 - Remove support for non-libxul builds. r=ted,joedrew

#ifeq ($(MOZ_WIDGET_TOOLKIT),cocoa)
#DISABLED_CMMSRCS		= gfxTestCocoaHelper.mm
#HELPER_OBJS	= gfxTestCocoaHelper.$(OBJ_SUFFIX)
#EXTRA_DEPS	+= gfxTestCocoaHelper.$(OBJ_SUFFIX)
#endif

# CPP_UNIT_TESTS disabled for now because they dont work in libxul builds.
#ifndef BUILD_STATIC_LIBS
#
#CPP_UNIT_TESTS	= \
#		TestColorNames.cpp \

#LIBS		= \
#		$(HELPER_OBJS) \
#		$(call EXPAND_LIBNAME_PATH,thebes,../thebes) \
#		$(call EXPAND_LIBNAME_PATH,gkgfx,../src) \
#		$(MOZ_UNICHARUTIL_LIBS) \
This is just another case of standalone C++ tests that we disabled when we removed --disable-libxul. These could all probably become gtests.
(Assignee)

Comment 2

5 years ago
I have a patch to fix some CPPSRCS tests but not all. For CMMSRCS I only see 'gfxTestCocoaHelper.mm' which is a simple and trivial memory pool test. I don't see any value in it and perhaps we should just delete it rather then port it.

Are there any other files I'm not seeing or does this bug just cover this file.
(Assignee)

Comment 3

5 years ago
Created attachment 758770 [details] [diff] [review]
Remove gfxTestCocoaHelper

Trivial test I'm not interested in porting.
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #758770 - Flags: review?(joe)
Attachment #758770 - Flags: review?(joe) → review+

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ee5b6ada4a03
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.