879916 - gfx/tests/Makefile.in - commented CMMSRCS=

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

gfx/tests/Makefile.in

Commented entries in the makefile will need to be cleaned up/purged or re-enabled.

changeset:   70003:8e846d7f21ea
date:        Mon May 23 18:54:47 2011 +0200
summary:     Bug 648911 - Remove support for non-libxul builds. r=ted,joedrew

#ifeq ($(MOZ_WIDGET_TOOLKIT),cocoa)
#DISABLED_CMMSRCS		= gfxTestCocoaHelper.mm
#HELPER_OBJS	= gfxTestCocoaHelper.$(OBJ_SUFFIX)
#EXTRA_DEPS	+= gfxTestCocoaHelper.$(OBJ_SUFFIX)
#endif

# CPP_UNIT_TESTS disabled for now because they dont work in libxul builds.
#ifndef BUILD_STATIC_LIBS
#
#CPP_UNIT_TESTS	= \
#		TestColorNames.cpp \

#LIBS		= \
#		$(HELPER_OBJS) \
#		$(call EXPAND_LIBNAME_PATH,thebes,../thebes) \
#		$(call EXPAND_LIBNAME_PATH,gkgfx,../src) \
#		$(MOZ_UNICHARUTIL_LIBS) \

Comment 1

[(not currently active) Ted Mielczarek]

This is just another case of standalone C++ tests that we disabled when we removed --disable-libxul. These could all probably become gtests.

Comment 2

[Benoit Girard (:BenWa)]

I have a patch to fix some CPPSRCS tests but not all. For CMMSRCS I only see 'gfxTestCocoaHelper.mm' which is a simple and trivial memory pool test. I don't see any value in it and perhaps we should just delete it rather then port it.

Are there any other files I'm not seeing or does this bug just cover this file.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: Remove gfxTestCocoaHelper

Trivial test I'm not interested in porting.

Comment 4

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee5b6ada4a03

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ee5b6ada4a03