879931 - Email reminder and instructions to contributors and mentors of unlanded patches

Status: RESOLVED INVALID

(Participation Infrastructure :: API Requests, task)

Description

[Benjamin Smedberg]

This is a tool request discussed at today's coding-contribute meeting. I'm filing it in this component because there wasn't an obvious product/component to dump it into.

lizzard noticed while triaging "good first bug"s that there were a significant number of patches which had completed review but had never been checked in, some as many as 2 years old. This sometimes results from cultural difference between Mozilla and many other projects: in many other projects, the reviewer checks in a patch after reviewing it. At Mozilla the contributor is typically responsible for getting the patch pushed. Nowadays that is typically as easy as adding the checkin-needed keyword to a bug. Except for new contributors who don't have editbugs and therefore can't add the keyword.

In order to keep patches from slipping through the cracks, we'd like to send reminder emails using the following criteria:

* For patches which have received review+ more than one week ago
* If the patch attachment is still marked r+
* If the patch attachment is not marked obsolete
* If the patch attachment is not marked checkin+
* On bugs which are still open
* If "leave open" is not present in the whiteboard

Email a set of people a reminder email about the patch:

* The patch author
* The bug owner, if that is different from the patch author
* The bug mentor (from the new field which will be added in bug 649691)
* If no mentor is listed, the patch reviewer

The reminder should only be sent once per bug.

The reminder email should tell the bug owner that they are responsible for getting the patch landed, and they should set the checkin-needed keyword or ask for help if necessary.

There should be a link to https://developer.mozilla.org/en-US/docs/Introduction

Comment 1

[(not currently active) Ted Mielczarek]

Any reason to prefer private email over just posting in the bug?

Also, some more specific doc links:
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 2

[Josh Matthews [:jdm]]

You're right, that would probably be easier and similarly effective.

Comment 3

[Jérémy Dagorn]

I would like to tackle this issue/feature. That would be my first contribution, is it OK?

Comment 4

[Josh Matthews [:jdm]]

Absolutely! Writing this tool using an existing library such as https://github.com/williamh/pybugz (python) or https://github.com/harthur/bz.js (javascript) makes the most sense to me. Are the requirements clear?

Comment 5

[Jérémy Dagorn]

Yes it is pretty clear. Just finishing setting up my devenv, and will work on it. What is the best way for us to communicate? I am on IRC, #commtools jrm2k6.

Comment 6

[Josh Matthews [:jdm]]

Asking questions on IRC or in this bug is fine. I'm often on IRC in #introduction and #developers as jdm.

Comment 7

[Jérémy Dagorn]

Great, let's just assign it to me then, that way it is clear for everybody.

Comment 8

[Josh Matthews [:jdm]]

Jérémy, do you still intend to work on this?

Comment 9

[Jérémy Dagorn]

Yes, I do. Do you have a deadline on it? If it is urgent, give it to someone else.

Comment 10

[Josh Matthews [:jdm]]

No deadline; I just wanted to make sure your name was still correct as the assignee.

Comment 11

[Greg Cox [:gcox]]

Closing due to inactivity, reopen if needed.