Closed Bug 879998 Opened 11 years ago Closed 11 years ago

Remove some dead code

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(2 files)

Patch
17.59 KB, patch
Ms2ger
: review+
emk
: review+
Details | Diff | Splinter Review
Dead code in content
5.04 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch Patch — — Splinter Review 

        Attachment #758815 -
        Flags: review?(Ms2ger)

    
    

    
  


  
Assignee: nobody → dzbarsky

        Attachment #758979 -
        Flags: review?(bugs)

    
    

    
  
Comment on attachment 758815 [details] [diff] [review]
Patch

Review of attachment 758815 [details] [diff] [review]:
-----------------------------------------------------------------

Could you check the change to EncodingUtils?

        Attachment #758815 -
        Flags: review?(VYV03354)

    
    

    
  
Comment on attachment 758815 [details] [diff] [review]
Patch

Dead function. Everybody uses nsContentUtils::CheckForBOM().

        Attachment #758815 -
        Flags: review?(VYV03354) → review+

        Attachment #758979 -
        Flags: review?(bugs) → review+

    
    

    
  
Comment on attachment 758815 [details] [diff] [review]
Patch

Review of attachment 758815 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

        Attachment #758815 -
        Flags: review?(Ms2ger) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/313de3a7c9e2
https://hg.mozilla.org/mozilla-central/rev/53318030bbb1
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: