OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #759448 - Flags: review?(justin.lebar+bug)
Comment on attachment 759448 [details] [diff] [review] PAtch The idea here is fine, but the one-liner to check for is-main-process is XRE_GetProcessType() == GeckoProcessType_Default (I'd love to improve this, but we should probably do so all at once, and not in nsFrameMessageManager.h. But that's probably out of scope for this bug.)
Attachment #759448 - Flags: review?(justin.lebar+bug) → review-
I'd probably also leave the NS_NewGlobalMessageManager code unchanged. We have very poor testing of debug builds in B2G, so there's no guarantee that we'd notice if we were hitting this assertion. And anyway, XPCOM semantics are to return an error, rather than to assert, and this is definitely XPCOM code.
Comment on attachment 759858 [details] [diff] [review] Patch r=me, but could you add a comment saying that the globalmm only exists in the root process?
Attachment #759858 - Flags: review?(justin.lebar+bug) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.