Lots of WARNING: NS_ENSURE_TRUE(IsChromeProcess()) failed: file /content/base/src/nsFrameMessageManager.cpp, line 728

RESOLVED FIXED in mozilla24

Status

()

defect
RESOLVED FIXED
6 years ago
5 months ago

People

(Reporter: reuben, Assigned: dzbarsky)

Tracking

Trunk
mozilla24
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

819 bytes, patch
justin.lebar+bug
: review+
Details | Diff | Splinter Review
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Posted patch PAtch (obsolete) — Splinter Review
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #759448 - Flags: review?(justin.lebar+bug)
Comment on attachment 759448 [details] [diff] [review]
PAtch

The idea here is fine, but the one-liner to check for is-main-process is

   XRE_GetProcessType() == GeckoProcessType_Default

(I'd love to improve this, but we should probably do so all at once, and not in nsFrameMessageManager.h.  But that's probably out of scope for this bug.)
Attachment #759448 - Flags: review?(justin.lebar+bug) → review-
I'd probably also leave the NS_NewGlobalMessageManager code unchanged.  We have very poor testing of debug builds in B2G, so there's no guarantee that we'd notice if we were hitting this assertion.  And anyway, XPCOM semantics are to return an error, rather than to assert, and this is definitely XPCOM code.
Posted patch PatchSplinter Review
Attachment #759448 - Attachment is obsolete: true
Attachment #759858 - Flags: review?(justin.lebar+bug)
Comment on attachment 759858 [details] [diff] [review]
Patch

r=me, but could you add a comment saying that the globalmm only exists in the root process?
Attachment #759858 - Flags: review?(justin.lebar+bug) → review+
https://hg.mozilla.org/mozilla-central/rev/b9b9d53a5c2d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.