Closed Bug 880062 Opened 7 years ago Closed 7 years ago

WMFReader should call SetMediaSeekable when the media isn't seekable

Categories

(Core :: Audio/Video, defect)

x86_64
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: cpearce, Assigned: cpearce)

References

()

Details

Attachments

(1 file)

We break playing this file:

https://bugzilla.mozilla.org/attachment.cgi?id=758811

STR:
1. On Windows, open https://bugzilla.mozilla.org/attachment.cgi?id=758811
2. Seek, note that playback pauses.

Expected STR:
playback should continue, ignoring the seek.
Attached patch PatchSplinter Review
Patch, with test. Unfortunately the test file doesn't play on Windows 7, so the test only runs on Windows 8. It'll run, and presumably pass, once we enable GStreamer on Linux, since GStreamer on Linux can currently play but not seek in that file.
Attachment #760777 - Flags: review?(paul)
Comment on attachment 760777 [details] [diff] [review]
Patch

Review of attachment 760777 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/manifest.js
@@ +323,5 @@
> +
> +// These are files that are non seekable, due to problems with the media,
> +// for example broken or missing indexes.
> +var gUnseekableTests = [
> +  { name:"bogus.duh", type:"bogus/duh"}

I know kinetik has a couple broken webm files somewhere we could add to this list.

::: content/media/test/test_unseekable.html
@@ +11,5 @@
> +<script class="testbody" type="text/javascript">
> +
> +/*
> +
> +Test that unseekable media can't seek seeked. We load a media that shouldn't

"can't be seeked".
Attachment #760777 - Flags: review?(paul) → review+
Fixed typo, and added a WebM file to gUnseekableTests that doesn't have any Cues:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b80b8b25e9d9
https://hg.mozilla.org/mozilla-central/rev/b80b8b25e9d9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.