Closed Bug 880129 Opened 7 years ago Closed 7 years ago

WebAudio Assertion failure: mWriteIndex <= bufferSize [@mozilla::dom::AnalyserNode::AppendChunk]

Categories

(Core :: Web Audio, defect, critical)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: posidron, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, crash, testcase)

Attachments

(3 files, 1 obsolete file)

Attached file testcase (obsolete) —
No description provided.
Attached file callstack
Attached file testcase
reduced testcase
Attachment #758991 - Attachment is obsolete: true
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #759595 - Flags: review?(roc)
Comment on attachment 759595 [details] [diff] [review]
Patch (v1)

Review of attachment 759595 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/AnalyserNode.cpp
@@ +281,5 @@
> +    // Copy a maximum bufferSize samples.
> +    chunkCount = bufferSize;
> +  }
> +
> +  PodCopy(mBuffer.Elements() + mWriteIndex, static_cast<const float*>(aChunk.mChannelData[0]), chunkCount);

chunkCount is a terrible name here. It's not the count of chunks. Call it chunkDuration.
Attachment #759595 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/728ac315adcb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.