880153 - WindowButtonsReservedWidth fallback is incorrect on Snow Leopard (10.6)

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Matthew N. [:MattN]]

Attachment: Screenshot of buttons on Lion vs. Snow Leopard

It seems like we usually hit the WindowButtonsReservedWidth fallback value of 61 pixels wide but that's not enough for the caption buttons as they were larger prior to Lion. This is causing tabstrip buttons to overlap the zoom button.

If I delete the -moz-appearance: -moz-window-button-box and re-add it in DOMi, it gets a value of 64px on SL. Based on the screenshot it would seem like 65px would be the comparable value. Any idea where the 1px difference comes from?

Comment 1

[Markus Stange [:mstange]]

(In reply to Matthew N. [:MattN] from comment #0)
> Based on the screenshot it would seem
> like 65px would be the comparable value. Any idea where the 1px difference
> comes from?

Looks like on 10.7/10.8, the button rect includes 1px of margin at the right, and on 10.6 it didn't. These values are really up to the system, and it looks like that's just what the creators of the native window buttons chose to do.

I think we should just use 64px as the fallback value on 10.6. I think the one pixel of gap difference isn't going to be noticeable, especially due to the rounded tab shape.

Comment 2

[Markus Stange [:mstange]]

Attachment: patch

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 759023 [details] [diff] [review]
patch

Looks fine to me.

Comment 4

[Markus Stange [:mstange]]

https://hg.mozilla.org/projects/ux/rev/d35fd3f2b033

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/d35fd3f2b033