Update the name of 'unknown device' once we suddenly know its name

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: echou, Assigned: arthurcc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
During Bluetooth discovering, when a device is found, Gecko Bluetooth would fire a DeviceFound event with the information of the found device. Sometimes we get all properties except 'name' since retrieving the name of a device is not as easy as other information in terms of Bluetooth protocol, and these devices would be shown 'Unknown Device'.

However, the device could be 'found' many times during one discovering period, and it is possible that the name would be retrieved successfully so it may be sent with DeviceFound after it was named 'Unknown Device'. In this case, we should update the name of the device in order to give users accurate device information.
(Reporter)

Comment 1

5 years ago
The same issue was also mentioned in bug 869858 comment 18.
(Reporter)

Updated

5 years ago
See Also: → bug 869858
(Reporter)

Updated

5 years ago
blocking-b2g: --- → koi?
(Reporter)

Comment 2

5 years ago
Nominate as koi? since I think it's an improvement to user experience.
Assignee: nobody → arthur.chen
Created attachment 759067 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/10239

Evelyn, could you help review it? The patch has been tested by Eric and it works well.
Attachment #759067 - Flags: review?(ehung)

Comment 4

5 years ago
Comment on attachment 759067 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/10239

r=me, there is a duplicate bug 882680 and I review the patch there first. To be honest, I like the coding style there, it's much readable. But your patch is a complete one, includes updating an unknown paired device's name, and l10n id stuff. 
Anyway, I'd like to r+ your patch, and I've passed the review request of bug 882680 to you. Please merge one and mark another as a dup. Thanks a lot!
Attachment #759067 - Flags: review?(ehung) → review+
Thanks for reviewing!
master: https://github.com/mozilla-b2g/gaia/commit/3f11b5201f9410fdeaa38fca41f37ea991570020
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Duplicate of this bug: 882680
(Reporter)

Updated

5 years ago
Duplicate of this bug: 869858
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.