FM radio callbacks FM_RADIO_OPERATION_ENABLE when trying to disable it

RESOLVED FIXED

Status

Firefox OS
Hardware
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: slee, Assigned: slee)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.32 KB, patch
slee
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
It shouldn't callback FM_RADIO_OPERATION_ENABLE when disabling FM radio.
(Assignee)

Comment 1

5 years ago
Created attachment 759602 [details] [diff] [review]
patch - v2

Hi Justin, 
Could you please review my patch when you have time? If you are too busy to review, please tell me.

Thanks
Attachment #759602 - Flags: review?(justin.lebar+bug)
>+ // The driver callback TAVARUA_EVT_RADIO_READY when we turn on and turn off it.

I'm not sure, but maybe you mean

  Don't send an update about an enabled FM radio if we're in the process of disabling the radio.  (The driver sends TAVAURA_EVT_RADIO_READY when we quickly turn the radio on and then off.)

?
Comment on attachment 759602 [details] [diff] [review]
patch - v2

r=me with the comment sorted out.
Attachment #759602 - Flags: review?(justin.lebar+bug) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Justin Lebar [:jlebar] from comment #2)
> I'm not sure, but maybe you mean
> 
>   Don't send an update about an enabled FM radio if we're in the process of
> disabling the radio.  (The driver sends TAVAURA_EVT_RADIO_READY when we
> quickly turn the radio on and then off.)
> 
Hi Justin,

I meant TAVAURA_EVT_RADIO_READY will always be sent when we turn off the FM radio so that we need to check additional flags.
Oh, I see.  That's pretty weird!

If your comment said something like

  // The driver sends RADIO_READY both when we turn the radio on and when we turn the radio off.

that would be clearer to me.
(Assignee)

Comment 6

5 years ago
Created attachment 760764 [details] [diff] [review]
patch - v3
Attachment #759602 - Attachment is obsolete: true
Attachment #760764 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/projects/birch/rev/b3dfd511e52b

Can we get a test for this?
Flags: in-testsuite?
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b3dfd511e52b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
No longer blocks: 913343
You need to log in before you can comment on or make changes to this bug.