880173 - Treestatus staging and prod should use different memcached keys since the memcached server is shared

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

Broken out from bug 879732.

(In reply to Chris Turra [:cturra] from comment #6)
> :edmorley - one thought that i have is if stage and prod are sharing
> memcache keys? i see in the treestatus.wsgi file we define the
> memcached.servers, but don't see any memcache key config. is it possible
> both these environments are using the same keys? and if so, can we add a
> config option to prepend the keys with treestatus_<env> or something similar?


(In reply to Chris AtLee [:catlee] from comment #10)
> The memcached keys do support prefixing, but it's not exposed in a useful
> way right now. I assumed the memcached servers for dev/stage/prod were all
> separate.
> 
> It shouldn't be too hard to support a new config value in the .wsgi that
> gets passed down to modify memcachePrefix.
> 
> https://github.com/mozilla/treestatus/blob/master/treestatus/app.py#L27

Side note: This explains a lot of the weirdness I've seen periodically when using staging! doh!

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 2

[Ed Morley [:emorley]]

Thank you :-)

https://github.com/mozilla/treestatus/commit/0a1583f1f19ed732b1d4bb0abd08b8556b49935e

I'll request that the configs be updated prior to push to staging/prod, in the push request bug.

Comment 3

[Ed Morley [:emorley]]

In production :-)