Closed
Bug 880222
Opened 11 years ago
Closed 11 years ago
May month is displayed with dot ("May. 31") in status bar
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: hwguy.siplus, Assigned: anirudh24seven)
Details
Attachments
(1 file)
46 bytes,
patch
|
kaze
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release) Build ID: 20130511120803 Steps to reproduce: Looked at the status bar in May. Actual results: The month is displayed with dot in the end ("May. 31, Carrier"), even though it's the full name of the month, unlike "Jan.", "Feb.", "Mar." Expected results: The month should have been displayed without the dot ("May 31, Carrier"). However, other months should've been displayed with the dot ("Jun. 30, Carrier"). The solution is to change the format of the United States localization of date representation from "%s. %i" to "%s %i" and to add the dot directly to the months' names.
Assignee | ||
Comment 1•11 years ago
|
||
I am not sure if the fix would be to add the dot directly to the month's names. My suggestion would be to remove the dot itself. All months would look consistent and we could save real estate by removing that character.
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8341135 -
Flags: review?(kaze)
Yes, this is okay. 3-letter month names are so common that they don't need a dot.
Comment 4•11 years ago
|
||
Comment on attachment 8341135 [details] [diff] [review] Proposed patch for suggested fix. Thanks!
Attachment #8341135 -
Flags: review?(kaze) → review+
Comment 5•11 years ago
|
||
Merged on master: https://github.com/mozilla-b2g/gaia/commit/b4e2f8e060c8cc7385a2986cf1c26616e0058c13
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 6•11 years ago
|
||
Anirudh, it'd be great if you could add the bug number to your commit message for your next patch. I was trying to find this commit, and only got to the bug through kaze's merge commit. Also, I agree that not changing the ID here is a good idea. Kaze, would you mind posting a tip to the .l10n group, explaining this change? Other localizations might want to follow suit.
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #6) > Anirudh, it'd be great if you could add the bug number to your commit > message for your next patch. Sure. I will do so.
Updated•10 years ago
|
Assignee: nobody → anirudh24seven
You need to log in
before you can comment on or make changes to this bug.
Description
•