Closed Bug 880240 Opened 7 years ago Closed 7 years ago

Update Firefox Logo on device

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

All
Other
defect

Tracking

(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)

VERIFIED FIXED
1.1 QE3 (26jun)
blocking-b2g leo+
Tracking Status
b2g18 --- verified
b2g-v1.1hd --- fixed

People

(Reporter: epang, Assigned: pivanov)

Details

Attachments

(2 files, 1 obsolete file)

406.73 KB, application/x-zip-compressed
Details
183 bytes, text/html
sjochimek
: review+
Details
Update the Firefox logo in for locations:

1. Browser Start Page
2. App Permissions
3. Boot Sequence
4. Application Icon

Image assets will be attached when ready.

Thanks!
Eric, can you advise on when the image assets would be due in order to make 1.1?
(In reply to John Slater from comment #1)
> Eric, can you advise on when the image assets would be due in order to make
> 1.1?

Hi John, Stephany will be adding in the timing and tags since she has a better scope of v1.1.
John, I'm going to request this be "milestoned" to fit into the QE3 cycle and timeline that's just starting this week, as that seems to make the most sense. That target (for full completion) is June 26, so the sooner you can create assets for this the better shape we'll be in, ideally within the next week. I'll follow up with triage and release as to getting this formally associated with a milestone, if that's even necessary (though we should follow that timeline to improve likelihood of this getting in).

Where there are assets to attach to this, we can begin the process of review, approval and uplift to v1-train.
Target Milestone: --- → 1.1 QE3
blocking-b2g: --- → leo+
Waiting on confirmation from Eric that he'll be the one creating the final assets. In the meantime, here's Eric's full list of deliverables from our email thread:

1. Browser Start Page: 165 x 165px, 330 x 330px 
2. App Permissions: 30 x 30px, 60 x 60px
3. Boot Sequence: 62 x 62 px, 124 x124px
4. Application Icon: 60 x 60px (i'll use the one from app permissions), 120 x 120px
5. About Firefox OS: 50 x 50 px, 100 x 100 px
Eric confirmed over email that he'll be creating the assets in comment #4 based on the original files created by Sean. Thanks!
Attached file Logos to Update (obsolete) —
Hi Pavel,
Can you please update with the attached images.  These will be direct image swaps.

I've included both normal size and @2x of each.

In the zip file you will find 2 folders:
1. New Assets - contains all the new assets
2. Updated Logo Needed (Screens) - You can use these screens to reference the logo locations.

Feel free to update the file names of the image assets to match the files that already exist :). Please let me know if I need to update any of the images as I wasn't 100% sure how the current versions were formatted. 

Let me know if you have any questions, thanks!
Comment on attachment 760326 [details]
Logos to Update

Hi Eric: Are these ready for review?
(In reply to Stephany Wilkes from comment #7)
> Comment on attachment 760326 [details]
> Logos to Update
> 
> Hi Eric: Are these ready for review?

Hi Stephany, not yet :).  Pavel needs to swap them out the images first and attach the patch.
Flags: needinfo?(pivanov)
Hey Eric,
There are two versions of images:
https://github.com/mozilla-b2g/gaia/tree/master/shared/resources/branding/official
https://github.com/mozilla-b2g/gaia/tree/master/shared/resources/branding/unofficial
 ... official and unofficial version and I think you should check the images there and if needed I will change them but I think we should save the size of the current images.
Flags: needinfo?(pivanov)
Attached file Logos to Update
Hi Pavel, thanks for the link to the images.  I've updated them here, please use these updated versions to replace the current ones.

Also, don't worry about updating the unofficial images, they can stay as is.  

Thanks!
Attachment #760326 - Attachment is obsolete: true
Flags: needinfo?(pivanov)
Attached file patch for Gaia repo
just images replacement
Attachment #761082 - Flags: review?(sjochimek)
Flags: needinfo?(pivanov)
(In reply to Pavel Ivanov [:ivanovpavel] from comment #11)
> Created attachment 761082 [details]
> patch for Gaia repo
> 
> just images replacement

Thanks for finishing this so quickly Pavel! :)
Comment on attachment 761082 [details]
patch for Gaia repo

Landed in master: https://github.com/mozilla-b2g/gaia/commit/6a17febce2551cd3a764bb3bce39fe9ca88c5ca4
Attachment #761082 - Flags: review?(sjochimek) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to Sam Joch [:samjoch] from comment #13)
> Comment on attachment 761082 [details]
> patch for Gaia repo
> 
> Landed in master:
> https://github.com/mozilla-b2g/gaia/commit/
> 6a17febce2551cd3a764bb3bce39fe9ca88c5ca4

Thanks Sam!

Naoki, this is ready for verification :).

Thanks!
Flags: needinfo?(nhirata.bugzilla)
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 6a17febce2551cd3a764bb3bce39fe9ca88c5ca4
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(pivanov)
Verified for Master:
name="gaia.git"revision="9dd0acc74c8e04218749917c85367a8080fa3cb1"
name="releases/mozilla-b2g18"  revision="f1b84d841ced"
name="gecko.git" revision="24aedf8ebbc56886f0e28e1d5aaba0f9b02e3a0f"
unagi-mozilla-b2g18-20130617070209-ril01.01.00.019.128

Will need same to follow comment 15 in order to get this in v1.1
Status: RESOLVED → VERIFIED
Flags: needinfo?(nhirata.bugzilla) → needinfo?(sjochimek)
Do i uplift @2x images in v1-train ?
Flags: needinfo?(timdream)
(In reply to Sam Joch [:samjoch] from comment #17)
> Do i uplift @2x images in v1-train ?

No. We will uplift that as part of Browser app. Thank you!
Flags: needinfo?(timdream)
uplifted in v1-train

6a17febce2551cd3a764bb3bce39fe9ca88c5ca4 -> 57a73f8c85fbe61fef95846a52c8a95bf83e0fbd
Flags: needinfo?(sjochimek)
Flags: needinfo?(pivanov)
1.1hd: 57a73f8c85fbe61fef95846a52c8a95bf83e0fbd
Flags: in-moztrap?
Flags: in-moztrap? → in-moztrap-
I don't understand the minus here. This is verifying that we have the right logo on the phone at the specified locations in comment 0. You need to create MozTrap test cases that match what's specified in comment 0.
Flags: in-moztrap- → in-moztrap?
Flags: in-moztrap? → in-moztrap?(ahubenya)
Verified as fixed on Leo Device with the variables below. The new logo appears in all the spot indicated above.

Environmental Variables
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.158
You need to log in before you can comment on or make changes to this bug.