Closed
Bug 880255
Opened 11 years ago
Closed 11 years ago
Add an implicit conversion from nsIntSize to IntSize
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file)
|
1.32 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #759127 -
Flags: review?(bgirard)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 759127 [details] [diff] [review] Add an implicit conversion from nsIntSize to IntSize Review of attachment 759127 [details] [diff] [review]: ----------------------------------------------------------------- r+ as long as operator typecast is well supported by our compiler. I haven't seen it in our code base.
Attachment #759127 -
Flags: review?(bgirard) → review+
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4edfa5a589ef
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
||
Comment 3•11 years ago
|
||
Why implicit?
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to :Ms2ger from comment #3) > Why implicit? I don't feel that strongly but since the types are basically the same with different names, I didn't feel there was any value to the reader from explicit conversion.
You need to log in
before you can comment on or make changes to this bug.
Description
•