880317 - Don't use nsIDOMDocument in nsScreen

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

It's much nicer this way.

Comment 1

[Mounir Lamouri (:mounir)]

Comment on attachment 759211 [details] [diff] [review]
Patch v1

Review of attachment 759211 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the cleanup.

::: dom/base/nsScreen.cpp
@@ +410,5 @@
>    nsCOMPtr<EventTarget> target = aEvent->InternalDOMEvent()->GetCurrentTarget();
> +  MOZ_ASSERT(target);
> +
> +  nsCOMPtr<nsIDocument> doc = do_QueryInterface(target);
> +  MOZ_ASSERT(doc);

I believe that you can keep the previous structure:
nsCOMPtr<EventTarget> target = ...;
nsCOMPtr<nsIDocument> doc = ...;
MOZ_ASSERT(target && doc);

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yes, but then you don't which of the two is null if the assert fires.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/7041298aa8d9