simplify some use of nsIScriptGlobalObjectOwner

RESOLVED FIXED in mozilla24

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
it seems like this interface is useless and we could just merge its functionality into other useful interfaces / objects, but for now I just wantto clean up the silliest stuff and see where we can get too.
(Assignee)

Comment 1

5 years ago
Created attachment 759329 [details] [diff] [review]
bug 880329 - remove nsIXULDocument::GetScriptGlobalObjectOwner
Attachment #759329 - Flags: review?(bugs)
(Assignee)

Comment 2

5 years ago
Created attachment 759330 [details] [diff] [review]
bug 880329 - move nsIScriptGlobalObjectOwner out of nsXULPrototypeScript::Compile()
Attachment #759330 - Flags: review?(bugs)

Comment 3

5 years ago
Comment on attachment 759329 [details] [diff] [review]
bug 880329 - remove nsIXULDocument::GetScriptGlobalObjectOwner

update NS_IXULDOCUMENT_IID
Attachment #759329 - Flags: review?(bugs) → review+

Comment 4

5 years ago
Comment on attachment 759330 [details] [diff] [review]
bug 880329 - move nsIScriptGlobalObjectOwner out of nsXULPrototypeScript::Compile()


>-    nsresult rv;
>+    NS_ASSERTION(aGlobal, "prototype doc has no script global");
>+    if (!aGlobal)
>+        return NS_ERROR_UNEXPECTED;
{} with if, please


>+    nsIScriptContext *context = aGlobal->GetScriptContext();
>+    NS_ASSERTION(context, "no context for script global");
>+    if (! context)
>+      return NS_ERROR_UNEXPECTED;
if (!context) {
    return NS_ERROR_UNEXPECTED;
}
Attachment #759330 - Flags: review?(bugs) → review+

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4c18bf4337fa
https://hg.mozilla.org/mozilla-central/rev/ca761338dcde
Assignee: nobody → trev.saunders
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.