880427 - Preserve application tags on update

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Chris DeCairos (:cade)]

Application tags can currently only be added by an administrator or through the "appTag" mechanism provided to our trusted apps.

As it stands, a user can easily overwrite any and all tags whether deliberately or not. 

This poses several problems:

1. When we feature any project on the front page and someone re-publishes it, they will likely overwrite any and all app tags.
2. If through a feedback tool we've yet to implement, someone flags content as inappropriate, the author can easily re-publish the project and overwrite the app tags.

Two possible solutions:

1. re-write the update route so that it preserves present app tags. We might also consider making sure our tools never show app tags applied to a project in their editors.

2. Split tags into another field aptly named "appTags". This has a couple implications:
  a) The client api will change, as will the interactions with elastic search.
  b) implementations on our sites will need to be updated

Conversations in IRC and my own experience with the api tell me that option 1 is better. Thus I will implement it.

Comment 1

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/79

this will preserve all application tags on an update.

Comment 2

[Matthew Schranz [:mjschranz]]

Comment on attachment 759414 [details] [review]
https://github.com/mozilla/MakeAPI/pull/79

Minor nits, but R+.

I'd still like to see this used on the remove route if possible.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/bb5ae389b666e1b63b74d7ae18db88e929b4c415
Fix Bug 880427 - Preserve Application tags on an update