Closed
Bug 880428
Opened 11 years ago
Closed 11 years ago
Fix some build warnings
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(1 file, 1 obsolete file)
|
4.77 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•11 years ago
|
Attachment #759388 -
Attachment is patch: true
Attachment #759388 -
Attachment mime type: message/rfc822 → text/plain
Attachment #759388 -
Flags: review?(bsmith)
|
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → dzbarsky
Attachment #759388 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #759388 -
Flags: review?(bsmith)
Attachment #759394 -
Flags: review?(bsmith)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 759394 [details] [diff] [review] Patch Review of attachment 759394 [details] [diff] [review]: ----------------------------------------------------------------- Drive by review ::: security/manager/ssl/src/nsIdentityChecking.cpp @@ -718,5 @@ > > typedef nsTArray< nsMyTrustedEVInfoClass* > testEVArray; > static testEVArray *testEVInfos; > static bool testEVInfosLoaded = false; > #endif You can remove the #endif here with the #ifdef on 745 as they are for the same condition
|
||
Comment 4•11 years ago
|
||
Comment on attachment 759394 [details] [diff] [review] Patch Review of attachment 759394 [details] [diff] [review]: ----------------------------------------------------------------- David, I've already rewritten the code for CertVerifier in another patch and I just r+d Ehsan's dead code removal in nsIdentityChecking.cpp so neither of these will be issues in a few days.
Attachment #759394 -
Flags: review?(brian)
|
|
||
Updated•11 years ago
|
Flags: needinfo?(brian)
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•