Closed
Bug 880490
Opened 11 years ago
Closed 11 years ago
Update theme check to return the correct version
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
2013-07-11
People
(Reporter: cvan, Assigned: kngo)
References
Details
(Whiteboard: [qa-])
When a theme's assets or information change, we should increment its version. https://github.com/mozilla/zamboni/blob/master/services/theme_update.py#L150
Reporter | ||
Comment 1•11 years ago
|
||
FYI: right now if you update a theme, its existing users won't get the update until that bug gets fixed.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ngoke
Assignee | ||
Comment 2•11 years ago
|
||
https://github.com/ngokevin/zamboni/commit/1788aa69cb2cf51118d58732d1426beaedcd404d#L0R799
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → 2013-07-11
Comment 3•11 years ago
|
||
Please add STR here or mark it with [qa-] if no QA is needed.
Flags: needinfo?(cvan)
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(cvan)
Whiteboard: [qa-]
Assignee | ||
Comment 4•11 years ago
|
||
https://theme-update-dev.allizom.org/en-US/themes/update-check/439921 https://theme-update-dev.allizom.org/en-US/themes/update-check/436363 Version increments on every re-upload/re-review.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 5•11 years ago
|
||
Looks good on prod: Themes with one version: https://versioncheck.addons.mozilla.org/en-US/themes/update-check/409358 https://versioncheck.addons.mozilla.org/en-US/themes/update-check/354644 Themes with two versions: https://versioncheck.addons.mozilla.org/en-US/themes/update-check/348407 https://versioncheck.addons.mozilla.org/en-US/themes/update-check/369344 Thanks, Kevin!
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•