Closed Bug 880502 Opened 6 years ago Closed 6 years ago

Including GraphicBuffer.h in LayersTypes.h causes ogg to not build on JB

Categories

(Core :: Graphics: Layers, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(3 files)

On JB, hardware/libhardware/include/hardware/hardware.h defines version_minor and version_major which causes OggCodecState.cpp to not build. GraphicBuffer.h ends up including hardware/hardware.h.
At least one include path is:
OggCodecState.h
MediaDecoderReader.h
ImageLayers.h
Layers.h
LayersTypes.h
<ui/GraphicBuffer.h>
Attachment #759532 - Flags: feedback?(mwu)
Something like this might help in tracking this down.
I don't really know how to build such that I hit this bug, locally.
Attachment #759534 - Flags: feedback?(mwu)
Neat! I was about to just give up and undef these on gonk.

GraphicBuffer.h is still included after applying your patch, though.

...
nsGUIEvent.h
nsIWidget.h
LayersTypes.h
GraphicBuffer.h

Working backwards to figure out the include path is somewhat tough. Couldn't follow backwards after nsGUIEvent.h.

I feel like we should try prying LayerRenderState out of LayersTypes.h..
(In reply to Michael Wu [:mwu] from comment #3)
> Neat! I was about to just give up and undef these on gonk.
> 
> GraphicBuffer.h is still included after applying your patch, though.
> 
> ...
> nsGUIEvent.h
> nsIWidget.h
> LayersTypes.h
> GraphicBuffer.h
> 
> Working backwards to figure out the include path is somewhat tough. Couldn't
> follow backwards after nsGUIEvent.h.
> 
> I feel like we should try prying LayerRenderState out of LayersTypes.h..

Agreed. nsIWidget should definitely never be including something like GraphicBuffer.
This moves an include so the #define version_major/version_minor crap in hardware/hardware.h gets defined early enough that things compile.
Assignee: nobody → mwu
Attachment #766084 - Flags: review?(cpearce)
Attachment #759532 - Flags: feedback?(mwu)
Attachment #766084 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/a51fbfd1e186
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Attachment #759534 - Flags: feedback?(mwu)
You need to log in before you can comment on or make changes to this bug.