Closed Bug 880555 Opened 7 years ago Closed 7 years ago

Fix --test-manifest option for non mochitest-plain

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla24

People

(Reporter: Felipe, Assigned: Felipe)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
mochitest-chrome for example doesn't work with the filtering provided by the --test-manifest json file because it's using the wrong test root in the regexp.

Simple fix. Note that I removed the "^" from the regexp, because for m-chrome the address in gTestList also contains "chrome://mochitets/content/" at the beginning. I think it's fine to drop the "^" because prepending the testRoot is enough guarantee that it's matching what it's trying to match
Attachment #759550 - Flags: review?(jmaher)
please see bug 868158, we have a new more streamlined version of manifests as well as support for chrome/browser-chrome!
Comment on attachment 759550 [details] [diff] [review]
Patch

Review of attachment 759550 [details] [diff] [review]:
-----------------------------------------------------------------

this is a good simple and safe patch, I would like to see an android and b2g try server run first though.  We are trying to get away from the current manifest format/support because it was just added in there quickly for android.  Please see bug 868158 for work that is done there.
Attachment #759550 - Flags: review?(jmaher) → review+
Here's a try run of the patch: https://tbpl.mozilla.org/?tree=Try&rev=e6437406bb48

Does it look all right?
looks great, thanks for kicking off that try run!
https://hg.mozilla.org/mozilla-central/rev/8b4b7306f981
Assignee: nobody → felipc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.