Closed
Bug 880613
Opened 11 years ago
Closed 11 years ago
(gonk-jb) Add build flag in UnixSocket to distinguish between bluez stack and bluedroid stack sockets
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 880610
1.3 Sprint 3 - 10/25
People
(Reporter: shawnjohnjr, Assigned: shawnjohnjr)
References
Details
Attachments
(1 file)
3.70 KB,
patch
|
echou
:
feedback+
|
Details | Diff | Splinter Review |
b2g based on ics version uses BlueZ header but after Android 4.2.2 it uses bluedroid. Using bluedroid, we shall include "hardware/bt_sock.h" instead of "bluetooth/bluetooth.h".
Assignee | ||
Updated•11 years ago
|
Blocks: b2g-bluedroid
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #809000 -
Flags: feedback?(echou)
Comment 2•11 years ago
|
||
Comment on attachment 809000 [details] [diff] [review] 0005-Check-flag-to-separate-bluez-dependency.patch Review of attachment 809000 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. f=me. ::: dom/bluetooth/BluetoothUnixSocketConnector.cpp @@ +64,3 @@ > b[5], b[4], b[3], b[2], b[1], b[0]); > } > super-nit: extra blank line.
Attachment #809000 -
Flags: feedback?(echou) → feedback+
Updated•11 years ago
|
Target Milestone: --- → 1.3 Sprint 3 - 10/25
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 4•11 years ago
|
||
Move patch to bug 880610.
You need to log in
before you can comment on or make changes to this bug.
Description
•