880633 - [CALL LOG] Select All button flash in white and text button dissapear

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[b.paloma]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130511120803

Steps to reproduce:

GECKO: 65bbcee
GAIA: 13c6246

Description: When we have 500 calls on Call Log, we stay on Missed (on Call Log), we press on edit button, we select a number and after we deselected it; the "Select All" button haven't got the text, it appears on white. If we leave of app and we go back into again, the button's text appears again.

I attach a video of the problem on this link (it's too big to attach here): https://www.dropbox.com/sh/5g563xed1xc6zcf/0_nwvk8zJX

Steps:
1) Launch Call Log
2) Tap Missed
3) Tap Edit Button
4) Select a number



Actual results:

Actual Result:

The "Select All" button appears without its text.


Expected results:

Expected Result:
The "Select All" button is showed with its text.

Comment 1

[b.paloma]

The correct link is: https://www.dropbox.com/s/uz6s78woq2v11bv/video3.mp4

Comment 2

[b.paloma]

This happens when we have any number of calls (not only when we have 500 calls)

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 763510 [details]
Associated PR.

Is there any concrete input you need from me? See https://groups.google.com/d/msg/mozilla.dev.gaia/_T_BTvJ4fJk/6RLVb_hFl5UJ on when to ask whom.

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Ups, sorry! It seems that since this is a wording issue it is the UX team the one to be contacted ;-) Thanks!

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Requesting info from :fxosux regarding the typo fix included in this patch (ttachment 763510) ;-) Thanks!

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

I meant sttachment 763510. Sorry!

Comment 8

[Stephany Wilkes]

Flagging Francis for the typo check requested in comment 6.

Comment 9

[Francis Djabri [:djabber]]

Attachment: Empty button

I don't see how this is a wording issue - the issue is that a button is appearing without any text. There is no typo as far as I can tell - just that text is not appearing. 

I checked out the patch and I still see errors. If I follow these steps:

1) Launch Call Log
2) Tap Missed
3) Tap Edit Button
4) Select a number

The "Select all" text no longer disappears. However, if I then take this step:

5) Tap "Deselect all" 

the text in the "Select all" button still disappears. See attached.

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Deselecting all entries

Hi Francis,

Did you have a look at the PR at https://github.com/mozilla-b2g/gaia/pull/10439/files ? There you'll see that the wording issue is regarding the "Select all" text which was previously as "Select All" in the file "dialer.en-US.properties".

On the other hand, when applying the patch I do not get the same behavior as you do, when I click on the "Deselect all" button I get everything as it should. Please see the new video attached (sorry my hand is somehow in the middle but I think it can be seen ;-) ).

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Paloma, it would be great if you could test my patch. If you do not know how, just contact me in Skype and I'll guide you ;-) Thanks!

Comment 12

[Germán Toro del Valle (:gtorodelvalle)]

Since I am not able to watch the video I just attached, here you are the same video in Dropbox: https://www.dropbox.com/s/pnlmj6yi1fmax9h/2013-06-19%2010.00.40.mp4

Comment 13

[Francis Djabri [:djabber]]

(In reply to gtorodelvalle from comment #10)
> Created attachment 764617 [details]
> Deselecting all entries
> 
> Hi Francis,
> 
> Did you have a look at the PR at
> https://github.com/mozilla-b2g/gaia/pull/10439/files ? There you'll see that
> the wording issue is regarding the "Select all" text which was previously as
> "Select All" in the file "dialer.en-US.properties".
> 

As per the guidelines at: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/UX/Style_guide

The text in all button should be in title case, and so "Select All". 

> On the other hand, when applying the patch I do not get the same behavior as
> you do, when I click on the "Deselect all" button I get everything as it
> should. Please see the new video attached (sorry my hand is somehow in the
> middle but I think it can be seen ;-) ).

The video only shows interaction in the "All" tab, not in the missed tab. I did check out the pull request above - it seems to work fine in the "All" tab for me as well, but not in the "Missed" tab.

Comment 14

[Germán Toro del Valle (:gtorodelvalle)]

Hey Fracis! First off, thank you very much for your feedback ;-) Really useful.

On the other hand and regarding the typo issue, according to the link you include in your latest comment the problem is not with the "Select All" text which is right but with the "Deselect all" which is not (please, see https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/locales/dialer.en-US.properties#L23). Right? I have updated the patch including this correction.

Last but not least, I have also fixed the problem when working with the "Missed" tab case. The "Select All" text should never disappear now :-) Would you be so kind to have a look at the new patch, please? Really appreciated ;-)

Comment 15

[Fernando Campo (:fcampo)]

Comment on attachment 763510 [details]
Associated PR.

Tested the new patch, and working as expected so far.

Code is ok, and even if I'd rather to locate the origin of the bug instead of fixing the consequences, German tells me that they've been trying for some time without any luck, so better to get this fixed ASAP, as it's leo+

Comment 16

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! Since I do already have Fernando's r+ from a technical perspective for the patch, it would be great to have the OK from Francis or anyone from UX regarding the typo correction included in this patch (see https://github.com/mozilla-b2g/gaia/pull/10439/files#L2L23) before merging it. Thank you very much!

Comment 17

[Stephany Wilkes]

This comment indicates UX approval for typo correction. Clearing both UX needinfo flags.

Comment 18

[Germán Toro del Valle (:gtorodelvalle)]

Thanks Stephany! ;-) (also to Fernando for the technical review)

Merged in master: https://github.com/mozilla-b2g/gaia/commit/14ac90d36dfe596dceae3bd843e953d3bbefe97b

Comment 19

[Germán Toro del Valle (:gtorodelvalle)]

Due to the divergence of the v1.0.1 branch (not including the latest Call Log refactoring), the uplifting to v1.0.1 will require some manual work. Please, require info from me to do it once it is correctly uplifted to v1-train and v1.1.0hd. Thanks!

Comment 20

[Axel Hecht [:Pike]]

This has leo+, and thus shouldn't go to 1.0.1. Please email release-mgmt@m.c if you disagree.

I guess this bug needs to be marked FIXED to be considered for uplift, is there any reason it's still open?

Comment 21

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Axel Hecht [:Pike] from comment #20)
> This has leo+, and thus shouldn't go to 1.0.1. Please email release-mgmt@m.c
> if you disagree.
> 
> I guess this bug needs to be marked FIXED to be considered for uplift, is
> there any reason it's still open?

If not uplifted to 1.0.1, the problem will persist in that version. That is why I set the v1.0.1 flag to affected. I'll contact you via email ;-)

Evolving the bug to FIXED. It seems I forgot :-( Sorry!

Comment 22

[Germán Toro del Valle (:gtorodelvalle)]

Merged in master: https://github.com/mozilla-b2g/gaia/commit/14ac90d36dfe596dceae3bd843e953d3bbefe97b

Comment 23

[Germán Toro del Valle (:gtorodelvalle)]

Under discussion with [e-mail]...

Comment 24

[Jason Smith [:jsmith]]

(In reply to gtorodelvalle from comment #23)
> Under discussion with [e-mail]...

Just so this doesn't end up in QA's triage bucket - let's leave this as a wontfix for now. If you end up getting approval for landing, feel free to flip the flag to affected.

Comment 25

[Germán Toro del Valle (:gtorodelvalle)]

Thanks Jason! ;-) After discussing it with [e-mail], the decision is NOT to apply the patch (uplifting) to 1.0.1. So we are good regarding the flags now :-)

Comment 26

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 14ac90d36dfe596dceae3bd843e953d3bbefe97b to:
v1-train: 67995fd8d39e9ad61f49610059c18b487c59f803

Comment 27

[isabelrios]

Verified with unagi v1-train 07/15 build:
Gecko-1b888da
Gaia-55ed5e0
ref. ril

Comment 28

[buri.blff]

I found that the missed call can not be delete.

Delete one/all missed call -> the missed call disappears -> long press the home key -> close Dialer -> reopen Dialer -> call log -> the deleted missed call appears

Comment 29

[Germán Toro del Valle (:gtorodelvalle)]

Hi! It would be great if you could file a new bug in case that misbehavior persists ;-) Thanks!

Comment 31

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 67995fd8d39e9ad61f49610059c18b487c59f803