880645 - [CONTACTS] Order by last name option doesn't work well when item count>500

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[b.paloma]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130511120803

Steps to reproduce:


GECKO: 65bbcee
GAIA: 13c6246

DESCRIPTION: On Contacts App, the "Order by last name" option doesn't work because the list only is updated when you leave the app and go back into it.

> I attach a video of the problem on this link (it's too big to attach here): 
https://www.dropbox.com/s/fau1216qkj7kpiv/video6.mp4

STEPS:
1) Launch Contacts App
2) Tap on Settings
3) Click on Order by last name
4) Tap on Done
5) Check if list was ordered by last name




Actual results:

The list wasn't ordered by last name.


Expected results:

The list was ordered by last name.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Can reproduce in v1-train

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

We had a race condition when reseting the dom.

If we let the contacts list finish to load we were able to perform the operation, reseting the dom and getting the new data.

For huge contacts list this operation takes more time, so we are not reseting the dom.

Sending a patch that forces resetting the dom for the contact list when changing the order.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 10347

Comment 4

[Jose Manuel Cantera]

Comment on attachment 761554 [details]
Pointer to PR 10347

works and test passing

thanks!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/73095ca35ab66e817902316aafca12957726eb63

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 73095ca35ab66e817902316aafca12957726eb63 to:
v1-train: 8cffa2637b26bd9c6ec6fe029010632d7d572fed

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 8cffa2637b26bd9c6ec6fe029010632d7d572fed

Comment 8

[mdaniloff]

This has been verified, the list has been ordered by last name when "order by last name" is enabled


Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1