Closed Bug 880662 Opened 7 years ago Closed 7 years ago

YCbCrImageDataSerializer.cpp:53:10: warning: unused variable 'bufferInfoSize' [-Wunused-variable]

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

gfx/layers/YCbCrImageDataSerializer.cpp: In member function 'bool mozilla::layers::YCbCrImageDataDeserializerBase::IsValid()':

gfx/layers/YCbCrImageDataSerializer.cpp:53:10: warning: unused variable 'bufferInfoSize' [-Wunused-variable]
Looks like this was introduced by:
 http://hg.mozilla.org/mozilla-central/rev/d88ad8015ae4

That added this incarnation of IsValid(), with the unused variable:
 http://hg.mozilla.org/mozilla-central/rev/d88ad8015ae4#l3.53
and it looks like the variable is there because it *is* used in the original code, ShmemYCbCrImage::IsValid():
  http://hg.mozilla.org/mozilla-central/rev/d88ad8015ae4#l3.199
Blocks: 874726
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #759717 - Flags: review?(nical.bugzilla)
Attachment #759717 - Flags: review?(nical.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/859ee3960254
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.