Closed Bug 880678 Opened 13 years ago Closed 13 years ago

search broken!

Categories

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Product:
Marketplace Graveyard
Component:
Reviewer Tools
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2013-06-13

People

(Reporter: eviljeff, Assigned: robhudson)

Details

(Keywords: regression, Whiteboard: p=1)

Reviewer tool search is borked, probably after the 2013-06-06 push. This error is in the web console: [14:48:48.855] TypeError: t.reviewer_flags is undefined @ https://marketplace.cdn.mozilla.net/media/js/mkt/reviewers-min.js?build=bc854f3-51b10caa:5
Please could you provide STR? Does it fail on -dev too?
Flags: needinfo?(awilliamson)
(In reply to Stuart Colville [:scolville] from comment #1) > Please could you provide STR? Go to review queue (https://marketplace.firefox.com/reviewers/apps/queue/) Type in search box (anything - e.g. "Free") and hit search (no results) > Does it fail on -dev too? No
Flags: needinfo?(awilliamson)
The cause seems to be missing data on prod. The app.reviewer_flags is not being sent in the JSON response but it is on -dev.
Rob any ideas?
Flags: needinfo?(robhudson.mozbugs)
I see what's going on, and it's my fault. https://github.com/mozilla/zamboni/blob/master/mkt/search/api.py#L128-L131 If the 'search-api-es' waffle isn't enabled it calls the AppResource.dehydrate, which doesn't add those fields. We were supposed to flip search-api-es yesterday but ran into some ES troubles that IT is resolving currently. Once it's enabled this issue will resolve itself.
Flags: needinfo?(robhudson.mozbugs)
Priority: -- → P1
Target Milestone: --- → 2013-06-13
Assignee: nobody → robhudson.mozbugs
It doesn't look like the waffle will be switched soon so I fixed this. https://github.com/mozilla/zamboni/commit/110fc05 To verify we need to disable the 'search-api-es' waffle flag and test reviewer tool search. It should work with both the waffle enabled and disabled.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: p=1
There was a regression elsewhere so this got reverted.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://github.com/mozilla/zamboni/commit/6c4326e Fixed it a different way.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
verified fixed @ https://marketplace-dev.allizom.org/reviewers/apps/queue/
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.