Closed Bug 880745 Opened 7 years ago Closed 6 years ago

Defect - Intermittent browser_history.js | Items are not in grid, | Items unpinned, | Grid repopulated

Categories

(Firefox for Metro Graveyard :: Tests, defect, P3)

x86
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME
Firefox 24

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=23903644&tree=Mozilla-Inbound#error3
WINNT 6.2 mozilla-inbound pgo test metro-immersive on 2013-06-07 08:45:35 PDT for push aa9a38e68dcf
slave: t-w864-ix-035

08:49:42  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_history.js | Items are not in grid
08:49:42     INFO -  Stack trace:
08:49:42     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_history.js :: testHistoryStartUnpin :: line 185
08:49:42     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 192
08:49:42     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
08:49:42     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
08:49:42     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 187
08:49:46     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js :: onEvent :: line 276
08:49:46     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
08:49:46  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_history.js | Items unpinned
08:49:46     INFO -  Stack trace:
08:49:46     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_history.js :: testHistoryStartUnpin :: line 186
08:49:46     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 192
08:49:46     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
08:49:46     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
08:49:46     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 187
08:49:46     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js :: onEvent :: line 276
08:49:46     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
08:49:46  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_history.js | Grid repopulated
08:49:46     INFO -  Stack trace:
08:49:46     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_history.js :: testHistoryStartUnpin :: line 187
08:49:46     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 192
08:49:46     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
08:49:46     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
08:49:46     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 187
08:49:46     INFO -      JS frame :: chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js :: onEvent :: line 276
08:49:46     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Attached patch Patch v1 (obsolete) — Splinter Review
Recent history tiles were off screen on smaller screens causing sendContextMenuClickToElement() to fail.

Fixed by scrolling.
Attachment #760025 - Flags: review?(jmathies)
Attachment #760025 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/68aaa8ae9d93
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Doesn't appear to be fully fixed, from inbound this morning:

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&showall=1&jobname=winnt%206.2&rev=deb589f7e2dc
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Patch v2Splinter Review
Tried another fix that shrinks the bookmarks grid after removing all elements. Grid.clearAll() removes all elements and sets the grid width to 0.  This gives more space to make history visible. Passed on try:

https://tbpl.mozilla.org/?tree=Try&rev=7791be5c5ca0&showall=1
Attachment #760025 - Attachment is obsolete: true
Attachment #761830 - Flags: review?(jmathies)
Attachment #761830 - Flags: review?(jmathies) → review+
Comment on attachment 761830 [details] [diff] [review]
Patch v2

much better, that's what clearAll is there for.
https://hg.mozilla.org/mozilla-central/rev/0b633f57cee4
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Assignee: rsilveira → nobody
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: metro-testing, 865451, metrov1defect&change
No longer blocks: 880298
Priority: -- → P3
Whiteboard: feature=defect c=testing u=developer p=0
Blocks: 880298
No longer blocks: metro-testing
Summary: Intermittent browser_history.js | Items are not in grid, | Items unpinned, | Grid repopulated → Defect - Intermittent browser_history.js | Items are not in grid, | Items unpinned, | Grid repopulated
No longer blocks: 865451
Wed haven't seen this in a month - resolving.
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → FIXED
No longer blocks: metrov2defect&change, 880298
Whiteboard: feature=defect c=testing u=developer p=0
Blocks: 880298
Resolution: FIXED → WORKSFORME
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.