Closed
Bug 880768
Opened 13 years ago
Closed 13 years ago
Add dual DB feature for old Thimble projects hosted at /p/:id
Categories
(Webmaker Graveyard :: Thimble, defect)
Webmaker Graveyard
Thimble
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: michiel)
References
Details
(Whiteboard: s=2013w24 p=1)
Attachments
(1 file)
Pomax, JP and I have been discussing the best way to continue hosting projects created in thimble-django. We've decided that the best compromise would be to:
1) Add a route for /p/:id and /p/:id/edit to the server that is enabled by an environment variable
2) Add a second sequelize connection for projects according to the thimble-django schema
3) Import all of the thimble-django data into this second DB
starting with some stubs on https://github.com/Pomax/thimble.webmaker.org/compare/bug880768
Updated•13 years ago
|
Whiteboard: s=2013w24 [migration] → s=2013w24 p=1
Updated•13 years ago
|
Severity: normal → blocker
database dump is on google drive; this doesn't have its own database, so:
mysql>CREATE DATABASE LegacyThimble;
mysql>CONNECT LegacyThimble;
mysql>SOURCE unpackedfile.sql;
mysql>RENAME TABLE api_page TO LegacyProjects;
then fire up "node app" (otherwise sequelize will build the table for us, which is not very useful, because it'll be empty)
Attachment #761091 -
Flags: review?(jon)
Comment 5•13 years ago
|
||
Comment on attachment 761091 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/115
Stealing review from Jon.
Attachment #761091 -
Flags: review?(jon) → review?(david.humphrey)
Comment 6•13 years ago
|
||
Comment on attachment 761091 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/115
I made a few minor comments/suggestions in the code. This looks sane to me. Let's do it on staging and test it a bunch today.
Attachment #761091 -
Flags: review?(david.humphrey) → review+
Comment on attachment 761091 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/115
fresh pull request, same code, pull comments from #112 worked in. Pretty sure this is the same code, routes etc. resolve correctly, but in the interest of safety this does require at least one pair of eyes to run over it just to be sure.
Attachment #761091 -
Attachment description: https://github.com/mozilla/thimble.webmaker.org/pull/112 → https://github.com/mozilla/thimble.webmaker.org/pull/115
Attachment #761091 -
Flags: review+ → review?
Attachment #761091 -
Flags: review? → review?(david.humphrey)
Comment 8•13 years ago
|
||
Comment on attachment 761091 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/115
On issue to fix, r+ with that.
Attachment #761091 -
Flags: review?(david.humphrey) → review+
landed as https://github.com/mozilla/thimble.webmaker.org/commit/17842143e732f06f84d16f1fabca50cca28b52c1
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•