Closed Bug 880775 Opened 11 years ago Closed 11 years ago

Birthday is shown timezone dependent and can result in a day off as it is, e.g .17 instead of 18

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, b2g18 affected, b2g-v1.2 verified)

Status:
RESOLVED FIXED
Milestone:
1.2 C2(Oct11)
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g18 --- affected
b2g-v1.2 --- verified

People

(Reporter: whimboo, Assigned: mai)

Details

Attachments

(1 file, 1 obsolete file)

patch 1.2
256 bytes, text/html
jmcf
: review+
Details 
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/09dc1ae3b1b5
Gaia   92a6e36957145cdb2ac8867e5cdba8ecf12308fc
BuildID 20130605070207
Version 18.0

When you have imported contacts from e.g. Google which have a birthday set, the contacts application shows this birthday as a day before:

Google contacts:       January 23rd
Firefox OS contacts:   January 22nd

This applies to all of my contacts which have been imported. As it looks like we start to count by 0 for the day of month instead of 1.
So now that I'm at home again the birthday is shown correctly again. This gives me the feeling that the output is timezone dependent which it should not be. In my case I was in PDT instead of MEZ and got a day earlier.
Summary: Birthday is shown as a day earlier as it is, e.g .17 instead of 18 → Birthday is shown timezone dependent and can result in a day off as it is, e.g .17 instead of 18
Assignee: nobody → francisco.jordano
Assignee: francisco.jordano → mri
Target Milestone: --- → 1.2 QE1(Oct11)
Attached file patch v1 - normalize birthday date (obsolete) — 
The birthday date is normalized by adding the timezone offset to avoid displaying errors when the timezone changes
Comment on attachment 812490 [details]
patch v1 - normalize birthday date

please, review the code.
Attachment #812490 - Flags: review?(jmcf)
Comment on attachment 812490 [details]
patch v1 - normalize birthday date

good work, 

thanks
Attachment #812490 - Flags: review?(jmcf) → review+
https://github.com/mozilla-b2g/gaia/commit/9d1a9fe8c40519f2bf7b558790a4df4d5b818ca3
Status: NEW → RESOLVED
blocking-b2g: --- → koi?
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #812490 - Attachment is obsolete: true
Attached file patch 1.2 — 

        Attachment #813455 -
        Flags: review?(jmcf)

    
    

    
  
Comment on attachment 813455 [details]
patch 1.2

ok, we will await for Travis green flag

        Attachment #813455 -
        Flags: review?(jmcf) → review+

    
    

    
  
relanded in master: now tests passing. sorry for breaking the build

https://github.com/mozilla-b2g/gaia/commit/05686b67e67e9cdf568ef22c179c42f6a5cfceac
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+

    
    

    
  
Uplifted 05686b67e67e9cdf568ef22c179c42f6a5cfceac to:
v1.2: fa8cfcd003b7d7b9bd17a7f30fc0d35845372d58

          status-b2g-v1.2:
          --- → fixed

    
    

    
  
Fix verified on Buri 1.2 mozilla RIL.  Changing the timezone no longer changes the birthdays on contacts.

Build ID: 20131017004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/7ca5d1e81d37
Gaia: dbcc171eae6b4d9d168a48291d5ea54c7580561a
Platform Version: 26.0a2

          status-b2g-v1.2:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: