Closed
Bug 880789
Opened 11 years ago
Closed 11 years ago
Remove the dropmarker from the Bookmarks button when its in the palette or panel
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M7][User Research Build+])
Attachments
(1 file)
1.12 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
We've just landed bug 880399, which takes the bookmark star out of the URL bar, and merges it with the bookmarks button as a split button. This button is customizable / removable, and still shows its dropmarker when its in the palette or the panel. That's probably not desirable.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 760416 [details] [diff] [review] Patch v1 Funny - I seem to recall this working at some point, but a blame on toolbarbutton.xml shows that it's been toolbarbutton-menubutton-dropmarker since at least the switch to hg: http://hg.mozilla.org/mozilla-central/annotate/9ca690835a5e/toolkit/content/widgets/toolbarbutton.xml#l72 Anyhow, this seems to fix it.
Attachment #760416 -
Flags: review?(jaws)
Comment 3•11 years ago
|
||
Comment on attachment 760416 [details] [diff] [review] Patch v1 Review of attachment 760416 [details] [diff] [review]: ----------------------------------------------------------------- That's because the previous rule was for the old bookmarks-menu-button, which does use toolbarbutton-menu-dropmarker. In the change from a menu to a menu-button, these class-names changed. http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/toolbarbutton.xml#41 http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/toolbarbutton.xml#72
Attachment #760416 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Jared Wein [:jaws] from comment #3) > Comment on attachment 760416 [details] [diff] [review] > Patch v1 > > Review of attachment 760416 [details] [diff] [review]: > ----------------------------------------------------------------- > > That's because the previous rule was for the old bookmarks-menu-button, > which does use toolbarbutton-menu-dropmarker. In the change from a menu to a > menu-button, these class-names changed. > > http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/ > toolbarbutton.xml#41 > http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/ > toolbarbutton.xml#72 Ah, of course. Thanks. :)
Assignee | ||
Comment 5•11 years ago
|
||
Landed in UX as https://hg.mozilla.org/projects/ux/rev/4d0ef7da3425
Whiteboard: [Australis:M7][User Research Build+] → [Australis:M7][User Research Build+][fixed-in-ux]
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4d0ef7da3425
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][User Research Build+][fixed-in-ux] → [Australis:M7][User Research Build+]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•