Remove the dropmarker from the Bookmarks button when its in the palette or panel

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 28
x86_64
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M7][User Research Build+])

Attachments

(1 attachment)

We've just landed bug 880399, which takes the bookmark star out of the URL bar, and merges it with the bookmarks button as a split button.

This button is customizable / removable, and still shows its dropmarker when its in the palette or the panel. That's probably not desirable.
Comment on attachment 760416 [details] [diff] [review]
Patch v1

Funny - I seem to recall this working at some point, but a blame on toolbarbutton.xml shows that it's been toolbarbutton-menubutton-dropmarker since at least the switch to hg: http://hg.mozilla.org/mozilla-central/annotate/9ca690835a5e/toolkit/content/widgets/toolbarbutton.xml#l72

Anyhow, this seems to fix it.
Attachment #760416 - Flags: review?(jaws)
Comment on attachment 760416 [details] [diff] [review]
Patch v1

Review of attachment 760416 [details] [diff] [review]:
-----------------------------------------------------------------

That's because the previous rule was for the old bookmarks-menu-button, which does use toolbarbutton-menu-dropmarker. In the change from a menu to a menu-button, these class-names changed.

http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/toolbarbutton.xml#41
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/toolbarbutton.xml#72
Attachment #760416 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] from comment #3)
> Comment on attachment 760416 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 760416 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> That's because the previous rule was for the old bookmarks-menu-button,
> which does use toolbarbutton-menu-dropmarker. In the change from a menu to a
> menu-button, these class-names changed.
> 
> http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/
> toolbarbutton.xml#41
> http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/
> toolbarbutton.xml#72

Ah, of course. Thanks. :)
Landed in UX as https://hg.mozilla.org/projects/ux/rev/4d0ef7da3425
Whiteboard: [Australis:M7][User Research Build+] → [Australis:M7][User Research Build+][fixed-in-ux]

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4d0ef7da3425
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][User Research Build+][fixed-in-ux] → [Australis:M7][User Research Build+]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.